From: Tomi Ollila Date: Mon, 10 Jun 2013 06:21:29 +0000 (+0300) Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2ba30ee61861eaa8c72a556db19edacbddd2f57e;p=notmuch-archives.git Re: [PATCH 2/2] emacs: Fix "no such file or directory" error --- diff --git a/41/6374c0c5bdec9e6243af8b9ae5c9b58ed9bc11 b/41/6374c0c5bdec9e6243af8b9ae5c9b58ed9bc11 new file mode 100644 index 000000000..c8b2692fb --- /dev/null +++ b/41/6374c0c5bdec9e6243af8b9ae5c9b58ed9bc11 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3891A431FAF + for ; Sun, 9 Jun 2013 23:21:53 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ovV5W3NEzFhl for ; + Sun, 9 Jun 2013 23:21:41 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 8CAE1431FAE + for ; Sun, 9 Jun 2013 23:21:41 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 6E745100044; + Mon, 10 Jun 2013 09:21:29 +0300 (EEST) +From: Tomi Ollila +To: Austin Clements , + Mark Walters +Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error +In-Reply-To: <20130610021534.GB22196@mit.edu> +References: <1370753138-15021-1-git-send-email-amdragon@mit.edu> + <1370753138-15021-3-git-send-email-amdragon@mit.edu> + <87hah7od8b.fsf@qmul.ac.uk> <20130610021534.GB22196@mit.edu> +User-Agent: Notmuch/0.15.2+172~ge989640 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Jun 2013 06:21:53 -0000 + +On Mon, Jun 10 2013, Austin Clements wrote: + +> Quoth Mark Walters on Jun 09 at 10:16 am: +>> +>> Both of these patches look good to me +1. I was able to reproduce both +>> bugs pretty reliably (the first one always unless masked by the second +>> one which occurred about half the time). With these patches I cannot +>> trigger either. Also all tests pass. +>> +>> My only tiny concern is I couldn't find any documentation on whether the +>> return value of the filter-function matters at all. Austin's original +>> fix (via irc) returned t and this returns nil in the failing case (i.e., +>> when results-buf is dead). +> +> Mm, interesting. To be fair, my choice of "t" for the original fix +> was completely arbitrary. I think you're right that the Emacs +> documentation doesn't have anything to say about the return values of +> filter functions. Furthermore, the example filter functions they give +> don't have meaningful return values, so I'm pretty sure this is safe. +> Also the code that calls the filter discards its result. + +I also looked this a bit yesterday evening. For example this page + +http://www.gnu.org/software/emacs/manual/html_node/elisp/Filter-Functions.html + +discusses only about catching thrown errors -- i.e. no mention about +filter function return values. From that I'd draw a conclusion that +most probably the return value of filter function is not used for anything. + +... and the patch looks good. +1 (removing needs-review) + +Tomi +