From: David Bremner <david@tethera.net>
Date: Sat, 27 Feb 2016 13:06:32 +0000 (+2000)
Subject: Re: [PATCH v3 07/16] create a notmuch_indexopts_t index options object
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2b48ae80dbaae00660ac51082c23a42f99d5b78d;p=notmuch-archives.git

Re: [PATCH v3 07/16] create a notmuch_indexopts_t index options object
---

diff --git a/41/5e932cc9973354389ee77887e38c17ffeab221 b/41/5e932cc9973354389ee77887e38c17ffeab221
new file mode 100644
index 000000000..832a606b5
--- /dev/null
+++ b/41/5e932cc9973354389ee77887e38c17ffeab221
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 676E96DE12E8
+ for <notmuch@notmuchmail.org>; Sat, 27 Feb 2016 05:06:37 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.036
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.036 tagged_above=-999 required=5
+ tests=[AWL=-0.025, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id iSJDiLLsQ41I for <notmuch@notmuchmail.org>;
+ Sat, 27 Feb 2016 05:06:35 -0800 (PST)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 437166DE0C3A
+ for <notmuch@notmuchmail.org>; Sat, 27 Feb 2016 05:06:34 -0800 (PST)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1aZeaX-0006eL-Oa; Sat, 27 Feb 2016 08:07:13 -0500
+Received: (nullmailer pid 3306 invoked by uid 1000);
+ Sat, 27 Feb 2016 13:06:32 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v3 07/16] create a notmuch_indexopts_t index options
+ object
+In-Reply-To: <1454272801-23623-8-git-send-email-dkg@fifthhorseman.net>
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
+ <1454272801-23623-8-git-send-email-dkg@fifthhorseman.net>
+User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sat, 27 Feb 2016 09:06:32 -0400
+Message-ID: <874mcu5mlj.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 27 Feb 2016 13:06:37 -0000
+
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+
+> +
+> +notmuch_indexopts_t *
+> +notmuch_indexopts_create ()
+> +{
+> +    notmuch_indexopts_t *ret;
+> +    
+> +    ret = talloc_zero (NULL, notmuch_indexopts_t);
+> +
+> +    return ret;
+> +}
+
+I have the same question about using talloc with a NULL context. It
+_looks_ like there is no actual benefit here?
+
+d
+