From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 2 Sep 2013 15:17:18 +0000 (+0300)
Subject: Re: [Patch v2 0/3] contrib: pick: remove an unused variable
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2b16b7c56257489978ee764467446d24572957ca;p=notmuch-archives.git

Re: [Patch v2 0/3] contrib: pick: remove an unused variable
---

diff --git a/8a/c3009fa10219ae10f1e5d089d14fa1fd9a6dc2 b/8a/c3009fa10219ae10f1e5d089d14fa1fd9a6dc2
new file mode 100644
index 000000000..b800ae1af
--- /dev/null
+++ b/8a/c3009fa10219ae10f1e5d089d14fa1fd9a6dc2
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 49C34431FC7
+	for <notmuch@notmuchmail.org>; Mon,  2 Sep 2013 08:17:33 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id FAiYMsk-O+e3 for <notmuch@notmuchmail.org>;
+	Mon,  2 Sep 2013 08:17:26 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id BE69A431FC3
+	for <notmuch@notmuchmail.org>; Mon,  2 Sep 2013 08:17:26 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 8EFC910005E;
+	Mon,  2 Sep 2013 18:17:18 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [Patch v2 0/3] contrib: pick: remove an unused variable
+In-Reply-To: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com>
+References: <1377551345-27147-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.16+45~g1eaad39 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 02 Sep 2013 18:17:18 +0300
+Message-ID: <m2hae3uubl.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 02 Sep 2013 15:17:33 -0000
+
+On Tue, Aug 27 2013, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> v2 of this series is at
+> id:1377460214-4795-1-git-send-email-markwalters1009@gmail.com
+>
+> v2 had a bug on refresh view (which I should have tested more). The
+> main pick view only worked by fluke as the initial call to pick-worker
+> was inside a let binding.
+>
+> This version fixes the bug, moves the call to pick-worker outside the
+> let binding (so the bug would have shown up sooner) and also adds a
+> test for refresh view.
+>
+> It is also rebased on top of
+> id:1377547043-17584-1-git-send-email-markwalters1009@gmail.com so that
+> series should be applied first.
+
+Looks Good, tests pass. +1
+
+>
+> Best wishes
+>
+> Mark
+
+Tomi
+
+
+>
+>
+> Mark Walters (3):
+>   contrib: pick: remove unneeded variable notmuch-pick-buffer-name
+>   contrib: pick: add docstring for notmuch-pick-worker
+>   contrib: pick: test: refresh view
+>
+>  contrib/notmuch-pick/notmuch-pick.el |   29 +++++++++++++----------------
+>  contrib/notmuch-pick/test/emacs-pick |   11 +++++++++++
+>  2 files changed, 24 insertions(+), 16 deletions(-)
+>
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch
+>
+
+-- 
+uussigu