From: Rob Browning Date: Sat, 1 Mar 2014 16:22:03 +0000 (+1800) Subject: Re: [DRAFT PATCH] notmuch new: do not ignore '.notmuch' in non-toplevel directories X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2b0e5a7d2ca747bfb920265e39f4262c402d2723;p=notmuch-archives.git Re: [DRAFT PATCH] notmuch new: do not ignore '.notmuch' in non-toplevel directories --- diff --git a/15/3efc25c90d0c418d359259199f7a8a66b519ca b/15/3efc25c90d0c418d359259199f7a8a66b519ca new file mode 100644 index 000000000..d1d22fe77 --- /dev/null +++ b/15/3efc25c90d0c418d359259199f7a8a66b519ca @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 16720431FC3 + for ; Sat, 1 Mar 2014 08:22:10 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XP2It1mdbpZt for ; + Sat, 1 Mar 2014 08:22:06 -0800 (PST) +Received: from defaultvalue.org (defaultvalue.org [70.85.129.156]) + by olra.theworths.org (Postfix) with ESMTP id 720C4431FC2 + for ; Sat, 1 Mar 2014 08:22:06 -0800 (PST) +Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) + (Authenticated sender: rlb@defaultvalue.org) + by defaultvalue.org (Postfix) with ESMTPSA id DF98890D2B; + Sat, 1 Mar 2014 10:22:03 -0600 (CST) +Received: by trouble.defaultvalue.org (Postfix, from userid 1000) + id 9014E14E14E; Sat, 1 Mar 2014 10:22:03 -0600 (CST) +From: Rob Browning +To: Mark Walters , Jani Nikula , + Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [DRAFT PATCH] notmuch new: do not ignore '.notmuch' in + non-toplevel directories +In-Reply-To: <87r46mgrxm.fsf@qmul.ac.uk> +References: <87mwhifu9a.fsf@trouble.defaultvalue.org> + <1393183127-31869-1-git-send-email-tomi.ollila@iki.fi> + <87ios5v59p.fsf@nikula.org> <87r46mgrxm.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Mar 2014 10:22:03 -0600 +Message-ID: <87ha7hvqhg.fsf@trouble.defaultvalue.org> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 01 Mar 2014 16:22:10 -0000 + +Mark Walters writes: + +> An alternative would be to ignore any .notmuch path with a xapian +> sub-directory. This would mean if a user indexed some subset of their +> mail before trying to index the whole thing they wouldn't accidentally +> index the old xapian database. + +If you wanted to be fairly careful, perhaps test for +exists(".notmuch/.xapian/flintlock" or ".notmuch/.xapian/iamchert"), or +some other very specific test. + +> I think the above was suggested by rlb on irc but I don't think it got +> any reply. + +Not sure. Though I'm wondering if I may have suggested we could add a +notmuch specific token file, i.e. .notmuch/this-really-is-a-notmuch-dir, +which lead to someone else suggesting we could just use .xapian. + +Of course broadly speaking, ".xapian" might be a legitimate maildir too, +but ".notmuch/.xapian" seems fairly unlikely. + +In any case, while I might prefer a very narrow test (as long as it +wasn't unduly expensive), all of the proposed solutions would have +handled my situation. + +Thanks +-- +Rob Browning +rlb @defaultvalue.org and @debian.org +GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A +GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4