From: Pete Wyckoff <pw@padd.com>
Date: Sun, 27 Jan 2013 03:11:22 +0000 (-0500)
Subject: git p4: avoid shell when invoking git config --get-all
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2abba3014e54920762eb81236e394af7b152f74c;p=git.git

git p4: avoid shell when invoking git config --get-all

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-p4.py b/git-p4.py
index c8ae83d50..7efa9a862 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -571,7 +571,8 @@ def gitConfig(key, args = None): # set args to "--bool", for instance
 
 def gitConfigList(key):
     if not _gitConfig.has_key(key):
-        _gitConfig[key] = read_pipe("git config --get-all %s" % key, ignore_error=True).strip().split(os.linesep)
+        s = read_pipe(["git", "config", "--get-all", key], ignore_error=True)
+        _gitConfig[key] = s.strip().split(os.linesep)
     return _gitConfig[key]
 
 def p4BranchesInGit(branchesAreInRemotes=True):