From: David Bremner Date: Tue, 4 Jun 2013 11:43:51 +0000 (+2100) Subject: Re: [PATCH] emacs: Fix applying stickiness to the :notmuch-part property X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2a92a819a9638018f100af8cdcd43629c0f5eb1f;p=notmuch-archives.git Re: [PATCH] emacs: Fix applying stickiness to the :notmuch-part property --- diff --git a/ad/b2959ac5d1a0bf536208061e6b2b88be6ce3f5 b/ad/b2959ac5d1a0bf536208061e6b2b88be6ce3f5 new file mode 100644 index 000000000..0ce496563 --- /dev/null +++ b/ad/b2959ac5d1a0bf536208061e6b2b88be6ce3f5 @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4A817431FB6 + for ; Tue, 4 Jun 2013 04:44:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pPr4B57zaTeo for ; + Tue, 4 Jun 2013 04:43:58 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 48057431FAF + for ; Tue, 4 Jun 2013 04:43:58 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r54Bhv3f008958; + Tue, 4 Jun 2013 08:43:57 -0300 +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1Ujpee-0001Rm-SB; Tue, 04 Jun 2013 08:43:57 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UjpeZ-0007up-8C; Tue, 04 Jun 2013 08:43:51 -0300 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Fix applying stickiness to the :notmuch-part + property +In-Reply-To: <1370272679-20175-1-git-send-email-amdragon@mit.edu> +References: <1370272679-20175-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+141~gd298af4 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 04 Jun 2013 08:43:51 -0300 +Message-ID: <87vc5uqex4.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Jun 2013 11:44:04 -0000 + +Austin Clements writes: + +> Previously, we simply called pushnew to add :notmuch-part to the +> front-sticky and rear-nonsticky text property lists. This works if +> these are nil or lists, but they can also have the value t, meaning +> that all properties are front-sticky/rear-nonsticky. In this case, +> pushnew will signal an error because t is not a list. We never set +> these properties to t ourselves, but since we apply these property +> changes over arbitrary renderer output, we have to deal with this +> possibility. + +Pushed, + +d