From: David Bremner <david@tethera.net>
Date: Thu, 23 Jan 2014 12:24:00 +0000 (-0400)
Subject: lib: make notmuch_threads_valid return FALSE when passed NULL
X-Git-Tag: 0.18_rc0~182
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=29f125212619ebca8621dd2106b412b22e1b6d22;p=notmuch.git

lib: make notmuch_threads_valid return FALSE when passed NULL

Without this patch, the example code in the header docs crashes for certain
invalid queries (see id:871u00oimv.fsf@approx.mit.edu)
---

diff --git a/lib/notmuch.h b/lib/notmuch.h
index 02604c56..68896ae7 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -802,6 +802,8 @@ notmuch_query_destroy (notmuch_query_t *query);
  * valid object. Whereas when this function returns FALSE,
  * notmuch_threads_get will return NULL.
  *
+ * If passed a NULL pointer, this function returns FALSE
+ *
  * See the documentation of notmuch_query_search_threads for example
  * code showing how to iterate over a notmuch_threads_t object.
  */
diff --git a/lib/query.cc b/lib/query.cc
index ec60e2e4..60ff8bd9 100644
--- a/lib/query.cc
+++ b/lib/query.cc
@@ -462,6 +462,9 @@ notmuch_threads_valid (notmuch_threads_t *threads)
 {
     unsigned int doc_id;
 
+    if (! threads)
+	return FALSE;
+
     while (threads->doc_id_pos < threads->doc_ids->len) {
 	doc_id = g_array_index (threads->doc_ids, unsigned int,
 				threads->doc_id_pos);