From: Matthieu Moy Date: Wed, 27 Jun 2012 09:10:16 +0000 (+0200) Subject: git-remote-mediawiki: don't compute the diff when getting commit message X-Git-Tag: v1.7.12-rc0~42^2~5 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=28c24bd7253c3c7a4f3134c5bae4d039b9838e87;p=git.git git-remote-mediawiki: don't compute the diff when getting commit message While we're there, simplify the code a bit: since log --format=%s anyway shows the subject line as a single line, no need to split to take the first line. Signed-off-by: Matthieu Moy Signed-off-by: Junio C Hamano --- diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki index 539718e24..e929b7a72 100755 --- a/contrib/mw-to-git/git-remote-mediawiki +++ b/contrib/mw-to-git/git-remote-mediawiki @@ -873,8 +873,8 @@ sub mw_push_revision { # TODO: we could detect rename, and encode them with a #redirect on the wiki. # TODO: for now, it's just a delete+add my @diff_info_list = split(/\0/, $diff_infos); - # Keep the first line of the commit message as mediawiki comment for the revision - my $commit_msg = (split(/\n/, run_git("show --pretty=format:\"%s\" $sha1_commit")))[0]; + # Keep the subject line of the commit message as mediawiki comment for the revision + my $commit_msg = run_git("log --no-walk --format=\"%s\" $sha1_commit"); chomp($commit_msg); # Push every blob while (@diff_info_list) {