From: David Bremner <david@tethera.net>
Date: Sat, 13 Aug 2016 13:23:23 +0000 (+0900)
Subject: Re: [PATCH v4 09/16] index encrypted parts when asked.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=286deade763be10e0386a1dd4b0dd3127a4dc370;p=notmuch-archives.git

Re: [PATCH v4 09/16] index encrypted parts when asked.
---

diff --git a/02/7cbafe8151d72b568febafa3f67e1b65a0f617 b/02/7cbafe8151d72b568febafa3f67e1b65a0f617
new file mode 100644
index 000000000..9b105db5e
--- /dev/null
+++ b/02/7cbafe8151d72b568febafa3f67e1b65a0f617
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id AE8566DE3C43
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 06:23:36 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.007
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id U8g3M1HZvSrw for <notmuch@notmuchmail.org>;
+ Sat, 13 Aug 2016 06:23:28 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 74B526DE3C3A
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 06:23:28 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
+ (envelope-from <david@tethera.net>)
+ id 1bYYua-0005l1-56; Sat, 13 Aug 2016 09:23:40 -0400
+Received: (nullmailer pid 24526 invoked by uid 1000);
+ Sat, 13 Aug 2016 13:23:23 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v4 09/16] index encrypted parts when asked.
+In-Reply-To: <1467970047-8013-10-git-send-email-dkg@fifthhorseman.net>
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
+ <1467970047-8013-10-git-send-email-dkg@fifthhorseman.net>
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sat, 13 Aug 2016 22:23:23 +0900
+Message-ID: <87bn0w6bw4.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 13 Aug 2016 13:23:36 -0000
+
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+
+> +    if (status) {
+> +	_notmuch_database_log (notmuch, "Warning: setup failed for decrypting "
+> +			       "during indexing. (%d)\n", status);
+> +	status = notmuch_message_add_property (message, "index-decryption", "failure");
+> +	if (status)
+> +	    _notmuch_database_log (notmuch, "failed to add index-decryption "
+> +				   "property (%d)\n", status);
+> +	return;
+> +    }
+
+Just as a reminder, _notmuch_database_log_append is now available for
+your logging needs. Other than that, this patch looks ok.
+