From: David Bremner <david@tethera.net>
Date: Sat, 17 Jan 2015 10:44:52 +0000 (+0100)
Subject: Re: [PATCH v3 1/5] Add failing unit tests for indexed mime types
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2795085966e8e2e79b44689065b76c8890e3c1d5;p=notmuch-archives.git

Re: [PATCH v3 1/5] Add failing unit tests for indexed mime types
---

diff --git a/55/146db5a540279cac7c1456c18d50c15845e056 b/55/146db5a540279cac7c1456c18d50c15845e056
new file mode 100644
index 000000000..8cabfa6ce
--- /dev/null
+++ b/55/146db5a540279cac7c1456c18d50c15845e056
@@ -0,0 +1,63 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id A2F39431FD9
+	for <notmuch@notmuchmail.org>; Sat, 17 Jan 2015 02:45:07 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 2.438
+X-Spam-Level: **
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
+	tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 195mYytmZjCG for <notmuch@notmuchmail.org>;
+	Sat, 17 Jan 2015 02:45:04 -0800 (PST)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 76C0A431FAF
+	for <notmuch@notmuchmail.org>; Sat, 17 Jan 2015 02:45:04 -0800 (PST)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1YCQsE-00068W-J3; Sat, 17 Jan 2015 06:44:58 -0400
+Received: (nullmailer pid 11748 invoked by uid 1000); Sat, 17 Jan 2015
+	10:44:52 -0000
+From: David Bremner <david@tethera.net>
+To: Todd <todd@electricoding.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v3 1/5] Add failing unit tests for indexed mime types
+In-Reply-To: <1421368229-4360-1-git-send-email-todd@electricoding.com>
+References: <1420849787-4401-1-git-send-email-todd@electricoding.com>
+	<1421368229-4360-1-git-send-email-todd@electricoding.com>
+User-Agent: Notmuch/0.19+20~g2bbe5e0 (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 17 Jan 2015 11:44:52 +0100
+Message-ID: <87vbk5wusb.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 17 Jan 2015 10:45:07 -0000
+
+Todd <todd@electricoding.com> writes:
+> +test_begin_subtest "search for non-existent mime-type"
+> +test_subtest_known_broken
+> +output=$(notmuch search mimetype:non-existent/mime-type | notmuch_search_sanitize)
+> +test_expect_equal "$output" ""
+> +
+
+This one is not in fact broken, since the search silently returns
+nothing in either case.  Not sure if others have stricter ideas, but for
+me it would be ok to remote this one test_subtest_known_broken and note
+the situation in the commit message.