From: David Bremner Date: Sun, 2 Mar 2014 19:11:15 +0000 (+2000) Subject: Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=27787ef37227b5a51efb7044958ac66a5e18ea8d;p=notmuch-archives.git Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix --- diff --git a/ee/46258f954a3190e31301b017cbe24f40ae82bf b/ee/46258f954a3190e31301b017cbe24f40ae82bf new file mode 100644 index 000000000..f8d12e285 --- /dev/null +++ b/ee/46258f954a3190e31301b017cbe24f40ae82bf @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3DF76431FBD + for ; Sun, 2 Mar 2014 11:11:27 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RKIpe95tZL65 for ; + Sun, 2 Mar 2014 11:11:22 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E467A431FBC + for ; Sun, 2 Mar 2014 11:11:22 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WKBnD-0004oI-7p; Sun, 02 Mar 2014 15:11:19 -0400 +Received: (nullmailer pid 17144 invoked by uid 1000); Sun, 02 Mar 2014 + 19:11:15 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/13] literal folder: prefix, new path: prefix +In-Reply-To: +References: +User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Mar 2014 15:11:15 -0400 +Message-ID: <87mwh8mn58.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Mar 2014 19:11:27 -0000 + +Jani Nikula writes: +> +> I've dropped most of the content in patches 7 and 10 due to their +> size. The patches (and the whole series) are available in the +> boolean-folder-and-path-v2 branch at +> git://gitorious.org/jani/notmuch.git. Web interface at +> https://gitorious.org/jani/notmuch/commits/0b3dd2d1cc6c413ea07ea326883ac448499c0e79. +> + +Hi Jani; + +I put a some proposed changes at + + http://pivot.cs.unb.ca/git?p=notmuch.git;a=shortlog;h=refs/heads/boolean-folder-and-path-v2 + +After playing with it a bit, I decided to + + - leave the source for the corpuses in the main tree. As we + discussed, we don't expect them to change much, and they are + text files. + + - store the binary database blobs externally. We could make the + same argument about infrequent changes here, except that even + the tiniest change will in practice require a whole new copy be + stored. + + - compute a checksum file + - test: add machinery to fetch and publish test databases + - test: commit database-v1.tar.xz checksum, ignore actual database + + - this is an independant bug fix that should probably be pushed anyway: + + - test: don't use $(dir) in recipes. + + - I also made some unrelated changes including switching to xz + compression. I intentionally didn't squash my patches into yours + so you see and decide + + - convert to XZ compression + - convert test to XZ + + Originally I thought metadata in the database tarball is + needed. It turns out not. I think it's harmless, but feel free + to drop it. + + - add some metadata to the database tarball + + - I struggled to find a way that would allow people to manage the + tarballs in a nice way while not requiring everyone to + install/learn new tools. My conclusion is in + + - test: add support for git annex managing test databases + +We still need to think about what to do for people installing from +tarballs. As it stands they will need to either have network access or +skip the relevant tests. Probably at least one followup patch is needed +here. The alternative would be to include the database tarballs in the +source; this will pretty quickly double the size of the source tarball. + +