From: Mark Walters Date: Thu, 19 Dec 2013 19:35:41 +0000 (+0000) Subject: Re: [PATCH v2 0/5] emacs: show: redesign unread/read logic X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=275c27a81229beadc3e78fd937ba1945235ccfa9;p=notmuch-archives.git Re: [PATCH v2 0/5] emacs: show: redesign unread/read logic --- diff --git a/4b/0657fda194bb664182ff87a1be3e8e09772ca5 b/4b/0657fda194bb664182ff87a1be3e8e09772ca5 new file mode 100644 index 000000000..a857ed586 --- /dev/null +++ b/4b/0657fda194bb664182ff87a1be3e8e09772ca5 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 14B67431FD8 + for ; Thu, 19 Dec 2013 11:35:57 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gZW9gxA2xvPP for ; + Thu, 19 Dec 2013 11:35:49 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CC9AC431FC4 + for ; Thu, 19 Dec 2013 11:35:48 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VtjNn-0001qu-SA; Thu, 19 Dec 2013 19:35:44 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VtjNn-0002VR-Id; Thu, 19 Dec 2013 19:35:43 +0000 +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/5] emacs: show: redesign unread/read logic +In-Reply-To: <1387065197-15776-1-git-send-email-markwalters1009@gmail.com> +References: <1387065197-15776-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+475~gaee1c24 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 19 Dec 2013 19:35:41 +0000 +Message-ID: <87iouktz02.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 9ceb3f260791f4059f788f366806f4bf (of first 20000 bytes) +X-SpamAssassin-Score: 0.6 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.6 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.4 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 19 Dec 2013 19:35:57 -0000 + + +Hi + +I have marked this series as obsolete as I have a cleaner way of doing +some of it. In particular, in my local tree the marking tags +deleted/added is done in such a way that it is easy for show, search and +tree to all use the functionality. + +However, any feedback on whether people like the way it behaves is still +very welcome! + +(As an aside one reason I like this functionality as well as for unread +handling is it means that changes made in one buffer can be shown in +another automatically without losing information: the original tags +remain clear to the user) + +Best wishes + +Mark + + +On Sat, 14 Dec 2013, Mark Walters wrote: +> Very impressively I managed to send v1 of this series backwards +> (having read through the patches with --reverse so that log showed +> them in the correct order I forgot to delete the --reverse for the +> send-email) +> +> Anyway this the series in the correct order. v1 (the reversed series) and +> proper cover-letter is at +> id:1387064676-15508-1-git-send-email-markwalters1009@gmail.com +> +> Best wishes +> +> Mark +> +> Mark Walters (5): +> test: make test_emacs call post-command-hook +> emacs: tree: make the tree code force the mark read update +> emacs: show: mark tags changed since buffer loaded +> emacs: show: add an update seen function to post-command-hook +> emacs: show: make `seen' mean user viewed whole message +> +> emacs/notmuch-show.el | 123 +++++++++++++++++++++++++++++++++++++++++-------- +> emacs/notmuch-tag.el | 105 ++++++++++++++++++++++++++++++------------ +> emacs/notmuch-tree.el | 3 + +> test/test-lib.el | 16 ++++++ +> test/test-lib.sh | 2 +- +> 5 files changed, 198 insertions(+), 51 deletions(-) +> +> -- +> 1.7.9.1