From: J. Lewis Muir Date: Fri, 6 Mar 2015 15:35:33 +0000 (+1800) Subject: Re: [PATCH v2] lib: make notmuch shared library install_name be full path on Mac... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=262d454ed7346391a732e18e1aab0202580526de;p=notmuch-archives.git Re: [PATCH v2] lib: make notmuch shared library install_name be full path on Mac OS X --- diff --git a/26/82614a27d753299df4b36843968730b58084ed b/26/82614a27d753299df4b36843968730b58084ed new file mode 100644 index 000000000..8ea3849d3 --- /dev/null +++ b/26/82614a27d753299df4b36843968730b58084ed @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7583E431FAF + for ; Fri, 6 Mar 2015 07:35:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aeIIPDgZ9df0 for ; + Fri, 6 Mar 2015 07:35:38 -0800 (PST) +Received: from tuna.imca.aps.anl.gov (tuna.imca.aps.anl.gov [164.54.200.33]) + by olra.theworths.org (Postfix) with ESMTP id 4FC9E431FAE + for ; Fri, 6 Mar 2015 07:35:38 -0800 (PST) +Received: from gromit.local (seal.imca.aps.anl.gov [164.54.200.39]) + by tuna.imca.aps.anl.gov (Postfix) with ESMTP id 336812005D + for ; Fri, 6 Mar 2015 09:35:33 -0600 (CST) +Message-ID: <54F9C945.5050007@imca-cat.org> +Date: Fri, 06 Mar 2015 09:35:33 -0600 +From: "J. Lewis Muir" +MIME-Version: 1.0 +To: notmuch@notmuchmail.org +Subject: Re: [PATCH v2] lib: make notmuch shared library install_name be full + path on Mac OS X +References: <1425508369-28448-1-git-send-email-jlmuir@imca-cat.org> + <8761aebo6t.fsf@maritornes.cs.unb.ca> +In-Reply-To: <8761aebo6t.fsf@maritornes.cs.unb.ca> +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: 7bit +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 06 Mar 2015 15:35:41 -0000 + +On 3/6/15 1:05 AM, David Bremner wrote: +> "J. Lewis Muir" writes: +> +>> The install_name of libnotmuch.dylib on Mac OS X is what is written +>> into a program that links against it. If it is just the name of +>> the shared library file, as opposed to the full path, the program +>> won't be able to find it when it runs and will abort. Instead, the +>> install_name should be the full path to the shared library (in its +>> final installed location). +> +> Pushed this version to master. Thanks for working with us on this. + +Hi, David. + +Great! Absolutely. Thank you! + +Lewis