From: David Bremner <david@tethera.net>
Date: Sun, 27 Oct 2013 12:29:17 +0000 (+2100)
Subject: Re: [PATCH 0/4] rename pick to tree
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=259c6297cf8ce208ec5dad8dff2b00772c794d16;p=notmuch-archives.git

Re: [PATCH 0/4] rename pick to tree
---

diff --git a/2c/01eccf3af89e5aaae29394502b5fc61ebc4b2a b/2c/01eccf3af89e5aaae29394502b5fc61ebc4b2a
new file mode 100644
index 000000000..66263b7be
--- /dev/null
+++ b/2c/01eccf3af89e5aaae29394502b5fc61ebc4b2a
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 16C2C431FDC
+	for <notmuch@notmuchmail.org>; Sun, 27 Oct 2013 05:29:52 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id LiypuNEwYW82 for <notmuch@notmuchmail.org>;
+	Sun, 27 Oct 2013 05:29:42 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 17F4F431FAF
+	for <notmuch@notmuchmail.org>; Sun, 27 Oct 2013 05:29:42 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1VaPT8-0001gs-L0; Sun, 27 Oct 2013 09:29:22 -0300
+Received: (nullmailer pid 29487 invoked by uid 1000); Sun, 27 Oct 2013
+	12:29:17 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, Mark Walters
+	<markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 0/4] rename pick to tree
+In-Reply-To: <m238nnt5hl.fsf@guru.guru-group.fi>
+References: <1382824928-3771-1-git-send-email-markwalters1009@gmail.com>
+	<m238nnt5hl.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.16+97~g6878b0b (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 27 Oct 2013 09:29:17 -0300
+Message-ID: <87k3gy523m.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 27 Oct 2013 12:29:52 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+>
+> LGTM. I will test (again) when the series posted to move this mainline
+> is submitted.
+>
+> Tomi
+>
+
+Looks OK to me as well. I did notice one warning about adding whitespace
+errors when applying patch 3/4. After staring at the patch a bit, I'm
+pretty sure that's the usual problem that the test data actually has
+trailing whitespace in it, so nothing to worry about.
+
+d