From: Jesse Rosenthal Date: Wed, 29 Oct 2014 13:07:32 +0000 (+2000) Subject: Re: [PATCH] Avoid empty thread names if possible. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=25402b00643ebe36432824d3c319eff7934933c2;p=notmuch-archives.git Re: [PATCH] Avoid empty thread names if possible. --- diff --git a/a5/466d2533521b534fe02333e3499d101742456a b/a5/466d2533521b534fe02333e3499d101742456a new file mode 100644 index 000000000..28be83447 --- /dev/null +++ b/a5/466d2533521b534fe02333e3499d101742456a @@ -0,0 +1,59 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8E8F7431FC2 + for ; Wed, 29 Oct 2014 06:07:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 06TKoHFkN6X5 for ; + Wed, 29 Oct 2014 06:07:37 -0700 (PDT) +Received: from smtpauth.johnshopkins.edu (smtpauth.johnshopkins.edu + [162.129.8.200]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9E62C431FB6 + for ; Wed, 29 Oct 2014 06:07:37 -0700 (PDT) +X-IronPort-AV: E=Sophos;i="5.04,809,1406606400"; d="scan'208";a="437386008" +Received: from guppy.hwcampus.jhu.edu (HELO localhost) ([10.161.32.234]) + by ipex1.johnshopkins.edu with ESMTP/TLS/AES128-SHA; + 29 Oct 2014 09:07:32 -0400 +From: Jesse Rosenthal +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] Avoid empty thread names if possible. +In-Reply-To: <87tx2nuvec.fsf@qmul.ac.uk> +References: <87oatnakqy.fsf@jhu.edu> <87tx2nuvec.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.18.2+155~gafa8535 (http://notmuchmail.org) Emacs/24.4.1 + (i686-pc-linux-gnu) +Date: Wed, 29 Oct 2014 09:07:32 -0400 +Message-ID: <87a94f2fe3.fsf@jhu.edu> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 29 Oct 2014 13:07:42 -0000 + +By the way, this discussion brings up another problem. I wasn't able to +write a test for this (to address the below concerns) because the test +suite for thread-naming supplies some sort of auto-generated subject +for threads with empty subjects. So we can't test behavior for dealing +with empty subjects. + +Unfortunately, I don't know the history of the test suite, or why this +auto-subject decisicion was made, so I don't feel comfortable just +changing the behavior.