From: Austin Clements Date: Sat, 23 Aug 2014 22:59:45 +0000 (+2000) Subject: Re: [PATCH v3 03/13] new: Don't report version after upgrade X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=23d6c800431db0b797453d596ebeb55154102057;p=notmuch-archives.git Re: [PATCH v3 03/13] new: Don't report version after upgrade --- diff --git a/5d/0624cf562f0a3fc17c2d44dc0ad51df4006fe3 b/5d/0624cf562f0a3fc17c2d44dc0ad51df4006fe3 new file mode 100644 index 000000000..f45c1cc0e --- /dev/null +++ b/5d/0624cf562f0a3fc17c2d44dc0ad51df4006fe3 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 908C7431FB6 + for ; Sat, 23 Aug 2014 15:59:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Cfc0niQiJwMK for ; + Sat, 23 Aug 2014 15:59:50 -0700 (PDT) +Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu + [18.9.25.14]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3E5D3431FAF + for ; Sat, 23 Aug 2014 15:59:50 -0700 (PDT) +X-AuditID: 1209190e-f79d46d000003643-83-53f91ce5038a +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP + id 48.B8.13891.5EC19F35; Sat, 23 Aug 2014 18:59:49 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s7NMxm4P025583; + Sat, 23 Aug 2014 18:59:49 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s7NMxk1X000726 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sat, 23 Aug 2014 18:59:48 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1XLKHi-0001EL-4i; Sat, 23 Aug 2014 18:59:46 -0400 +Date: Sat, 23 Aug 2014 18:59:45 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v3 03/13] new: Don't report version after upgrade +Message-ID: <20140823225945.GL3015@mit.edu> +References: <1406859003-11561-1-git-send-email-amdragon@mit.edu> + <1406859003-11561-4-git-send-email-amdragon@mit.edu> + <87siknjjvm.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87siknjjvm.fsf@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmphleLIzCtJLcpLzFFi42IR4hRV1n0q8zPY4PM5NYum6c4W12/OZHZg + 8rh1/zW7x7NVt5gDmKK4bFJSczLLUov07RK4Mta0XWcs+M5RceD4VLYGxinsXYycHBICJhJf + Gn6yQNhiEhfurWfrYuTiEBKYzSQxe/5VVghnI6PE/BnHoJzTTBLTHl9hgnCWMEo837GYCaSf + RUBVYuuRFawgNpuAhsS2/csZQWwRAUWJzSf3g9nMAtIS3343g9ULC7hKHNt/H6yeV0BbYvmV + 5VAbpjJKXOttg0oISpyc+YQFollL4sa/l0DNHGCDlv/jAAlzAu3qeLuaGcQWFVCRmHJyG9sE + RqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6xXm5miV5qSukmRnBgS/Lt + YPx6UOkQowAHoxIP74eLP4KFWBPLiitzDzFKcjApifIekvoZLMSXlJ9SmZFYnBFfVJqTWnyI + UYKDWUmE13U7UDlvSmJlVWpRPkxKmoNFSZz3rbVVsJBAemJJanZqakFqEUxWhoNDSYL3gjTQ + UMGi1PTUirTMnBKENBMHJ8hwHqDhW0BqeIsLEnOLM9Mh8qcYFaXEeTVAEgIgiYzSPLheWOJ5 + xSgO9Iow702QKh5g0oLrfgU0mAlo8PQZX0EGlyQipKQaGEskpJL0pwa/iDmkkcgmvm9nWOUD + PafJ6btrnfZvnbSF882+b5lrMhMulq7wm9Z3zfjXvqPbfedWJ2svbDIx2mlwYInZ44xVPu07 + 9tids2sTbuX59WXNp+Z/LLtN7q+RjROzMr6yxPL8RBWTjkfOM70+P1DWl+uY8zXScEv5c8dv + tw69F30R9EeJpTgj0VCLuag4EQAuMC1CFwMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 23 Aug 2014 22:59:56 -0000 + +Quoth Jani Nikula on Aug 23 at 6:39 pm: +> On Fri, 01 Aug 2014, Austin Clements wrote: +> > The version number has always been pretty meaningless to the user and +> > it's about to become even more meaningless with the introduction of +> > "features". Hopefully, the database will remain on version 3 for some +> > time to come; however, the introduction of new features over time in +> > version 3 will necessitate upgrades within version 3. It would be +> > confusing if we always tell the user they've been "upgraded to version +> > 3". If the user wants to know what's new, they should read the news. +> +> I think this is good for now. +> +> What do you think about adding notmuch_database_get_features(), and +> printing that? + +Mark had a similar comment, so here's my reply: +id:20140727162426.GF13893@mit.edu + +I'm happy with adding more transparency around this, though I'd prefer +to do it as follow-up to avoid expanding this series and because I'm +pretty sure adding something like notmuch_database_get_features +wouldn't require any non-trivial changes to the stuff in this series. + +> BR, +> Jani.