From: Jim Meyering <jim@meyering.net>
Date: Thu, 26 May 2011 14:34:20 +0000 (+0200)
Subject: sha1_file: use the correct type (ssize_t, not size_t) for read-style function
X-Git-Tag: v1.7.7-rc0~60^2~9
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=23c7df6bdd13e3d99ca09b6a7655747cc29ccc41;p=git.git

sha1_file: use the correct type (ssize_t, not size_t) for read-style function

Using an unsigned type, we would fail to detect a read error and then
proceed to try to write (size_t)-1 bytes.

Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/sha1_file.c b/sha1_file.c
index 5fc877fe4..8a8521799 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2733,7 +2733,7 @@ static int index_stream(unsigned char *sha1, int fd, size_t size,
 	while (size) {
 		char buf[10240];
 		size_t sz = size < sizeof(buf) ? size : sizeof(buf);
-		size_t actual;
+		ssize_t actual;
 
 		actual = read_in_full(fd, buf, sz);
 		if (actual < 0)