From: David Bremner Date: Sat, 18 May 2013 10:57:54 +0000 (+2100) Subject: Re: [PATCH] emacs: Proper error string handling in search sentinel X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2383d2a9f4675f9339474d56408558c3cb2f748b;p=notmuch-archives.git Re: [PATCH] emacs: Proper error string handling in search sentinel --- diff --git a/a4/a12c6fba3dbaeabde625ddc4b4e6d58aff6ed3 b/a4/a12c6fba3dbaeabde625ddc4b4e6d58aff6ed3 new file mode 100644 index 000000000..151ea575c --- /dev/null +++ b/a4/a12c6fba3dbaeabde625ddc4b4e6d58aff6ed3 @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1EF21431FC9 + for ; Sat, 18 May 2013 03:58:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ghAxfqOzGH1N for ; + Sat, 18 May 2013 03:58:03 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 70D5F431FC2 + for ; Sat, 18 May 2013 03:58:03 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4IAw1FA026964; + Sat, 18 May 2013 07:58:01 -0300 +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1Udeps-0000vy-Tf; Sat, 18 May 2013 07:58:01 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1Udepn-0002iN-7D; Sat, 18 May 2013 07:57:55 -0300 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Proper error string handling in search sentinel +In-Reply-To: <1368821668-24316-1-git-send-email-amdragon@mit.edu> +References: <1368821668-24316-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 18 May 2013 07:57:54 -0300 +Message-ID: <87vc6gd07h.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 18 May 2013 10:58:11 -0000 + +Austin Clements writes: + +> Apparently Emacs provides a function to stringify errors properly. +> Use this in the search sentinel where we have to do our own error +> messaging, rather than assuming the first error argument will be the +> descriptive string. + +Pushed. + +Mark, this should fix the problem with applying the asynch parser +series you noticed. + +d