From: W. Trevor King Date: Tue, 18 Feb 2014 18:48:04 +0000 (+1600) Subject: Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=23150ed2c8dd6f49a0d306699cafa455fdbe5206;p=notmuch-archives.git Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in OrderedDict stub --- diff --git a/55/1ed65a50ccfdedbf27a0a635c3ff47d62cc43d b/55/1ed65a50ccfdedbf27a0a635c3ff47d62cc43d new file mode 100644 index 000000000..18bcccd39 --- /dev/null +++ b/55/1ed65a50ccfdedbf27a0a635c3ff47d62cc43d @@ -0,0 +1,119 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 13893431FBD + for ; Tue, 18 Feb 2014 10:48:16 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UiuNVYacyzgz for ; + Tue, 18 Feb 2014 10:48:08 -0800 (PST) +Received: from qmta10.westchester.pa.mail.comcast.net + (qmta10.westchester.pa.mail.comcast.net [76.96.62.17]) + by olra.theworths.org (Postfix) with ESMTP id 28E2A431FBF + for ; Tue, 18 Feb 2014 10:48:08 -0800 (PST) +Received: from omta12.westchester.pa.mail.comcast.net ([76.96.62.44]) + by qmta10.westchester.pa.mail.comcast.net with comcast + id Tsaw1n0020xGWP85Auo623; Tue, 18 Feb 2014 18:48:06 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by omta12.westchester.pa.mail.comcast.net with comcast + id Tuo41n00m152l3L3Yuo5iu; Tue, 18 Feb 2014 18:48:06 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id 77AD8104C4D4; Tue, 18 Feb 2014 10:48:04 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1392749284; bh=jahNpham6/8/gN3mGNB5tC3bxVM2k1oaBml0636AJJY=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=IVQmEWBiQwJ5DWektYQBY0BQVOY91MC2hQkq0jtPSttUHo7SorY7tqTxmzuVD85k3 + DWsWXypDSqtJUgXx5ujmfMomJd5aYawhxoXFrQm6isfEKIohzBiPtAvEHo9VUHNBOW + 1FWV/r9gRlWyS1iLHIo4VzYfPn6EpnjZRT/YkR3c= +Date: Tue, 18 Feb 2014 10:48:04 -0800 +From: "W. Trevor King" +To: Tomi Ollila +Subject: Re: [PATCH 1/1] nmbug-status: replace __values__() with values() in + OrderedDict stub +Message-ID: <20140218184804.GW7538@odin.tremily.us> +References: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="1MV0VfA6Y2yiVCnw" +Content-Disposition: inline +In-Reply-To: <1392748492-29341-1-git-send-email-tomi.ollila@iki.fi> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.22 (2013-10-16) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20121106; t=1392749286; + bh=wdHMN24UBxXPOU+pBYSPDVX6MX0cCshkobcKHeVBi/s=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=LQczWA2O2ZKpRWPmVykG6xSMAZ81DlVSFwvDW91P4ZNt1O9V6JGYIiKNrNNxkrDQP + zRiJDrUmjkaavcfNPZQWk00Mbp5RT9879fVaaBSYrkJ2ycugNl4d1E9EVw2rmciVou + 6ktmJzeBThtIdCcCgY8XFNQxzUtHDyRivk1WsJ4LAs0MT5pGvUBvsgyqmBeBk1Xzv8 + YCmBxKcsmrTAWrR9ljKX4vWTTnWtfBl8A24tHLhEZ/qQcnWh32di+OWOt3SgmCaURD + 7lL1QyFPLcUNHBhMxkv7+3QtRbhuJwJHAvTXqRFVIax9lJpyjxaiCB0OZSS1rCio2q + eXPGkIR8+hPRw== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 18 Feb 2014 18:48:16 -0000 + + +--1MV0VfA6Y2yiVCnw +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Tue, Feb 18, 2014 at 08:34:52PM +0200, Tomi Ollila wrote: +> - def __values__(self): +> + def values(self): + +Looks good to me. I'm not sure why I used __values__ in the first +place; probably just in the __ zone after __init__ and __setitem__. + +Cheers, +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--1MV0VfA6Y2yiVCnw +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.22 (GNU/Linux) + +iQIcBAEBAgAGBQJTA6riAAoJEKKfehoaNkbtQHsP/2gYqKDVd8ic6rRMBDUrhe/7 +rvbjr0rtmJTYiBMs6ZN3Nchkz8FU0schGveLTCVo/sidf3BGXvXrGCrWci76pxJq +XewBuTtbH63pMOTSnv0O4RIOeFfjlIgCV+c628lEuyMVHqbFbRH6EOm6cqsLF02t +CewsnEDboy6WWlwFgzAQXr4qj2DEP8ao0/nQ8/t8dnja1uu3D2lLTQgypjy09TYZ +Mnd5MXlxadrznkgkKHJdUTv0nvBjpQCaTzmJD9QWlzu1Wnj9Yu+dwdOVN/yJNbQW +bjTfpGdo2nxQIwkDMXo13mJQMD5ROPwz7c8eOzSxedYcRN1ZHir2C535L2x9XpSv +blmCIzGjH8c8UHeIvJSauNCFY3fCD4RTzNoPcBL4OLLhP2t+AjjgLR9/WI80ZQye ++Ek0re2KeUF6835RL3KGli8qgQD+oSqvaDdstOQ8Ua+BnylT9qsiOGgSWXWZgDdK +c8qwnZRPzUTCM2C+sZkuBxtV+Gj7v6j8ia+k2GmnllRcEjTOZdmE4HyPkJPyQl90 +AMLTGWrRlujCKsgM4BzeZROLQ/YYvlNg7BUlh9D62xb5f7i/+D0JmLucWb63JC1C +zxZb0qlE5WhelEMX2BSPUh9wkTUiFrZlq8tElvIAvJ6/YtrD5zoe1D8xNI8APGEu +9DMz/+G9+fVtnlUJP5BO +=DzXC +-----END PGP SIGNATURE----- + +--1MV0VfA6Y2yiVCnw--