From: David Bremner Date: Sat, 25 Jan 2014 18:34:22 +0000 (+2000) Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=22a0ca38bb193d0af17ed73929f3ff15aa50c9eb;p=notmuch-archives.git Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el --- diff --git a/53/80e2b2f40f151acb258752b6e1b1572a203638 b/53/80e2b2f40f151acb258752b6e1b1572a203638 new file mode 100644 index 000000000..16adf9bfb --- /dev/null +++ b/53/80e2b2f40f151acb258752b6e1b1572a203638 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 78846431FBD + for ; Sat, 25 Jan 2014 10:34:33 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Pk+9GqXTn9q7 for ; + Sat, 25 Jan 2014 10:34:28 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BA06C431FBC + for ; Sat, 25 Jan 2014 10:34:28 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W783l-0003Qy-KZ; Sat, 25 Jan 2014 14:34:25 -0400 +Received: (nullmailer pid 3574 invoked by uid 1000); Sat, 25 Jan 2014 + 18:34:22 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el +In-Reply-To: <1329900529-16295-1-git-send-email-markwalters1009@gmail.com> +References: <87y5sipcjn.fsf@qmul.ac.uk> + <1329900529-16295-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.17+42~gb867564 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 25 Jan 2014 14:34:22 -0400 +Message-ID: <87bnyzoqq9.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 25 Jan 2014 18:34:33 -0000 + +Mark Walters writes: + +> ido-completing-read is used in notmuch-mua.el without any +> initialization. This should work but a bug (emacs bug #3247) in some +> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs +> to get stuck in the mini-buffer. This tests to see if ido-mode has +> been initialized and if not calls it. This avoids the bug for these +> older versions of emacs. +> +> This is the only place that ido-completing-read is used so an alternative +> would be to replace ido-completing-read by completing-read but cworth +> expressed a preference for the ido version in +> id:"87wrhfvk6a.fsf@yoom.home.cworth. + +This patch was tagged wip, but then there was no progress ;). It still +applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor +emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can +confirm it actually fixes the bug there. + +I propose we either apply the patch or ::wontfix the bug. + +cheers, + +d