From: David Bremner <david@tethera.net>
Date: Wed, 20 May 2015 08:12:31 +0000 (+0200)
Subject: [PATCH] configure: Add sanity checking for environment variables
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=21bda60de06258bc474601dc9f72207f22158c8e;p=notmuch-archives.git

[PATCH] configure: Add sanity checking for environment variables
---

diff --git a/fa/a1c07b88fe7b01af73034cec2b6b5397084253 b/fa/a1c07b88fe7b01af73034cec2b6b5397084253
new file mode 100644
index 000000000..affee2742
--- /dev/null
+++ b/fa/a1c07b88fe7b01af73034cec2b6b5397084253
@@ -0,0 +1,112 @@
+Return-Path: <bremner@tesseract.cs.unb.ca>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 90C706DE13EA
+ for <notmuch@notmuchmail.org>; Wed, 20 May 2015 01:15:24 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.297
+X-Spam-Level: 
+X-Spam-Status: No, score=0.297 tagged_above=-999 required=5 tests=[AWL=0.287, 
+ T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id jLMuswl6qLhB for <notmuch@notmuchmail.org>;
+ Wed, 20 May 2015 01:15:22 -0700 (PDT)
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
+ [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id C42486DE13DA
+ for <notmuch@notmuchmail.org>; Wed, 20 May 2015 01:15:21 -0700 (PDT)
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
+ 4.80) (envelope-from <bremner@tesseract.cs.unb.ca>)
+ id 1Yuz7m-0003UU-8B; Wed, 20 May 2015 08:13:10 +0000
+Received: (nullmailer pid 16941 invoked by uid 1000); Wed, 20 May 2015
+ 08:12:35 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,
+ Ronny Chevalier <chevalier.ronny@gmail.com>
+Subject: [PATCH] configure: Add sanity checking for environment variables
+Date: Wed, 20 May 2015 10:12:31 +0200
+Message-Id: <1432109551-16861-1-git-send-email-david@tethera.net>
+X-Mailer: git-send-email 2.1.4
+In-Reply-To: <m2617onuhh.fsf@guru.guru-group.fi>
+References: <m2617onuhh.fsf@guru.guru-group.fi>
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 20 May 2015 08:15:24 -0000
+
+Passing in environment variables incompatible with the compiler may
+cause other parts of the configure script to fail in hard to
+understand ways, so we abort early.
+---
+
+meh, the previous version was borken by lazy evaluation of CXXFLAGS
+using make syntax. Better suggestions for how to do this?
+
+ configure | 31 +++++++++++++++++++++++++++++--
+ 1 file changed, 29 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 4af7ba9..650b976 100755
+--- a/configure
++++ b/configure
+@@ -269,6 +269,35 @@ dependencies are available:
+ EOF
+ 
+ errors=0
++printf "int main(void){return 0;}\n" > minimal.c
++
++printf "Sanity checking C compilation environment... "
++if ${CC} ${CFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1
++then
++    printf "OK.\n"
++else
++    printf "Fail.\n"
++    errors=$((errors + 1))
++fi
++
++printf "Sanity checking C++ compilation environment... "
++if ${CXX} ${CXXFLAGS_for_sh} ${CPPFLAGS} minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1
++then
++    printf "OK.\n"
++else
++    printf "Fail.\n"
++    errors=$((errors + 1))
++fi
++
++if [ $errors -gt 0 ]; then
++    cat <<EOF
++*** Error: Initial sanity checking of environment failed.  Please try
++running configure in a clean environment, and if the problem persists,
++report a bug.
++EOF
++    rm -f minimal minimal.c
++    exit 1
++fi
+ 
+ if pkg-config --version > /dev/null 2>&1; then
+     have_pkg_config=1
+@@ -690,8 +719,6 @@ else
+ fi
+ rm -f compat/check_asctime
+ 
+-printf "int main(void){return 0;}\n" > minimal.c
+-
+ printf "Checking for rpath support... "
+ if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
+ then
+-- 
+2.1.4
+