From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 2 Jun 2013 14:32:31 +0000 (+0300)
Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2139ab6181a80c8c0a2cca3417e35a872cf4b630;p=notmuch-archives.git

Re: [PATCH] emacs: remove hardcoded defaults values from docstrings
---

diff --git a/6a/43422d06a49da78473d618382c1c2ff27255b1 b/6a/43422d06a49da78473d618382c1c2ff27255b1
new file mode 100644
index 000000000..8ce09e413
--- /dev/null
+++ b/6a/43422d06a49da78473d618382c1c2ff27255b1
@@ -0,0 +1,109 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 79C70421168
+	for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 07:32:38 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id mimxnANYm87v for <notmuch@notmuchmail.org>;
+	Sun,  2 Jun 2013 07:32:32 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 42BB1429E55
+	for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 07:32:32 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 759B8100030;
+	Sun,  2 Jun 2013 17:32:31 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: david@tethera.net, notmuch@notmuchmail.org
+Subject: Re: [PATCH] emacs: remove hardcoded defaults values from docstrings
+In-Reply-To: <1370181885-23021-1-git-send-email-david@tethera.net>
+References: <1370181885-23021-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 02 Jun 2013 17:32:31 +0300
+Message-ID: <m2d2s4d1mo.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: David Bremner <bremner@debian.org>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 02 Jun 2013 14:32:38 -0000
+
+On Sun, Jun 02 2013, david@tethera.net wrote:
+
+> From: David Bremner <bremner@debian.org>
+>
+> These functions refer to default values of variables, but it seems
+> less confusing and less likely to get out of date to just allow the
+> user to follow the help cross-reference links.
+> ---
+
+LGTM.
+
+Tomi
+
+
+>  emacs/notmuch-show.el | 14 ++++++--------
+>  1 file changed, 6 insertions(+), 8 deletions(-)
+>
+> another proposed change from our notmuch-pick discussions.
+>
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
+> index 613e666..600e802 100644
+> --- a/emacs/notmuch-show.el
+> +++ b/emacs/notmuch-show.el
+> @@ -1835,10 +1835,9 @@ search results instead."
+>    "Archive each message in thread.
+>  
+>  Archive each message currently shown by applying the tag changes
+> -in `notmuch-archive-tags' to each (remove the \"inbox\" tag by
+> -default). If a prefix argument is given, the messages will be
+> -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
+> -will be reversed.
+> +in `notmuch-archive-tags' to each. If a prefix argument is given,
+> +the messages will be \"unarchived\", i.e. the tag changes in
+> +`notmuch-archive-tags' will be reversed.
+>  
+>  Note: This command is safe from any race condition of new messages
+>  being delivered to the same thread. It does not archive the
+> @@ -1865,10 +1864,9 @@ buffer."
+>    "Archive the current message.
+>  
+>  Archive the current message by applying the tag changes in
+> -`notmuch-archive-tags' to it (remove the \"inbox\" tag by
+> -default). If a prefix argument is given, the message will be
+> -\"unarchived\", i.e. the tag changes in `notmuch-archive-tags'
+> -will be reversed."
+> +`notmuch-archive-tags' to it. If a prefix argument is given, the
+> +message will be \"unarchived\", i.e. the tag changes in
+> +`notmuch-archive-tags' will be reversed."
+>    (interactive "P")
+>    (when notmuch-archive-tags
+>      (apply 'notmuch-show-tag-message
+> -- 
+> 1.8.2.rc2
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch