From: David Edmondson Date: Mon, 12 May 2014 06:07:39 +0000 (+0100) Subject: Re: [PATCH v2] emacs: Add support for saved search accelerators X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=207b62adf76e2dfa0feb830cfaecdc0e2dcfe38f;p=notmuch-archives.git Re: [PATCH v2] emacs: Add support for saved search accelerators --- diff --git a/80/923ef992b253f68e95f583dd58bea61cd35846 b/80/923ef992b253f68e95f583dd58bea61cd35846 new file mode 100644 index 000000000..55247b529 --- /dev/null +++ b/80/923ef992b253f68e95f583dd58bea61cd35846 @@ -0,0 +1,118 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B6ACB431FC0 + for ; Sun, 11 May 2014 23:07:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1IdWds3LVRd3 for ; + Sun, 11 May 2014 23:07:55 -0700 (PDT) +Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com + [209.85.212.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CAB64431FBF + for ; Sun, 11 May 2014 23:07:54 -0700 (PDT) +Received: by mail-wi0-f179.google.com with SMTP id bs8so3868835wib.12 + for ; Sun, 11 May 2014 23:07:53 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=9O3EgGvEQQmfry8d0whzDl9KjSxUK4oEI5XR5IW9zTI=; + b=FvWPSgNk4XxpNS7Mf1r81hCF7V6pLnWC40QGtSsyiCVIZlgAF6DD36ol9pwz/KM6Rl + Ib3a0gWx6ovQhRhoutKvGVL7Iur+LhfeZFCqdk5lvlUhhZ/rlv0rQhwbZ9IlKhdvuDNY + Sm4WJB5+EhwTKUw2Igg2UikbJKcqdLEZc6vO0dpu4rDHji/IKnd1ysvZMEVSxvnLX+am + Dan+Hu5sLlfsLwGGl5YPqjFULj4JB25EPiJhgrHgBDCgsvcg9I7NWxwTiswD90US1ha+ + iW/F/pBbKs4R3+lKnP7DMZRxUtGwYK1Gjr2YxWnkViBpy9CCZCbrdgDoH6D4ExiW2vaC + Z+TA== +X-Gm-Message-State: + ALoCoQnD52bwzINtSlpojZMu7I+QCL8BAss5hBlO2jHbhm2y+YUKKimPTOhqXlmYK3hX2OR6c/UE +X-Received: by 10.194.92.177 with SMTP id cn17mr19704400wjb.18.1399874873568; + Sun, 11 May 2014 23:07:53 -0700 (PDT) +Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8]) + by mx.google.com with ESMTPSA id + t18sm14184413wiv.16.2014.05.11.23.07.51 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 11 May 2014 23:07:52 -0700 (PDT) +To: Aaron Ecay , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Add support for saved search accelerators +In-Reply-To: <87oaz5uzco.fsf@gmail.com> +References: <1399385776-19918-1-git-send-email-dme@dme.org> + <1399461694-25350-1-git-send-email-dme@dme.org> + <1399461694-25350-2-git-send-email-dme@dme.org> + <87zjislji0.fsf@qmul.ac.uk> <87oaz5uzco.fsf@gmail.com> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Mon, 12 May 2014 07:07:39 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 12 May 2014 06:07:59 -0000 + +--=-=-= +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable + +On Sat, May 10 2014, Aaron Ecay wrote: +> 2014ko maiatzak 8an, Mark Walters-ek idatzi zuen: +>> +>> Hi +>> +>> This version looks good to me. +>> +>> The only slight query I have is which key to bind it to: Austin used g +>> in notmuch-go and this uses j. Austin said on irc that he chose g +>> because it wasn't bound and matched gmail's shortcut. +>> +>> Personally I like j (as it starts fewer words than g) and given that we +>> don't match any of gmail's other bindings I don't think there is much +>> advantage to doing so in this case. +> +> All other things being equal, I=E2=80=99d prefer =E2=80=9Cj=E2=80=9D here= +, but for different +> reasons. =E2=80=9Cg=E2=80=9D is the emacs-standard key to refresh or rev= +ert a buffer. +> In my personal customization file I bound =E2=80=9Cg=E2=80=9D to +> notmuch-refresh-this-buffer in notmuch-(show/search)-mode-map long ago +> (and forgot this binding was not standard until reading above that g is +> not bound). It=E2=80=99s probably better emacs citizenship to not use su= +ch a +> standard key for a different purpose. + ++1, though I won't lose sleep. + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iKYEARECAGYFAlNwZStfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl +bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 +RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRZnwgCeNfUAOYzsuhzTLd5LnOpueGZH +cWoAn1PBZcgfTlzWGbuzBD3MhT/IYBWs +=meas +-----END PGP SIGNATURE----- +--=-=-=--