From: David Bremner <david@tethera.net>
Date: Sun, 30 Jun 2013 16:05:59 +0000 (+2100)
Subject: Re: [PATCH v2 1/3] contrib: pick: if no target specified go to first matching message
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2044d37aaef53ebf6dd490f61bcfe268fa89bf3d;p=notmuch-archives.git

Re: [PATCH v2 1/3] contrib: pick: if no target specified go to first matching message
---

diff --git a/2e/baae8e02d07c730a5989db35848563653b54ab b/2e/baae8e02d07c730a5989db35848563653b54ab
new file mode 100644
index 000000000..780840bfe
--- /dev/null
+++ b/2e/baae8e02d07c730a5989db35848563653b54ab
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id A3536431FBD
+	for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:06:09 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id Q3qb0iJ5v6MP for <notmuch@notmuchmail.org>;
+	Sun, 30 Jun 2013 09:06:03 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 8144B431FC2
+	for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:06:03 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1UtK8Z-0003Gi-1M; Sun, 30 Jun 2013 13:06:03 -0300
+Received: (nullmailer pid 13322 invoked by uid 1000); Sun, 30 Jun 2013
+	16:05:59 -0000
+From: David Bremner <david@tethera.net>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 1/3] contrib: pick: if no target specified go to first
+	matching message
+In-Reply-To: <1372582512-10777-2-git-send-email-markwalters1009@gmail.com>
+References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com>
+	<1372582512-10777-2-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 30 Jun 2013 13:05:59 -0300
+Message-ID: <87obantwgo.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 30 Jun 2013 16:06:09 -0000
+
+Mark Walters <markwalters1009@gmail.com> writes:
+> -  (let ((msg-id (notmuch-id-to-query (plist-get msg :id))))
+> -    (when (string= msg-id notmuch-pick-target-msg)
+> +  (let ((msg-id (notmuch-id-to-query (plist-get msg :id)))
+> +	(target notmuch-pick-target-msg))
+> +    (when (or (and (not target) (plist-get msg :match))
+> +	      (string= msg-id target))
+
+I can't really figure out from looking at the code what this 'target'
+business is about. Possibly unrelated to this patch, but maybe some
+documentation is needed?
+
+d