From: David Bremner Date: Mon, 12 May 2014 10:54:28 +0000 (+0900) Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1fb359a6f69885dc84c69fddc0ca0102d5fd30ff;p=notmuch-archives.git Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore. --- diff --git a/ce/1d879afedb118d03695c9df03005f05c64433c b/ce/1d879afedb118d03695c9df03005f05c64433c new file mode 100644 index 000000000..2399aebc3 --- /dev/null +++ b/ce/1d879afedb118d03695c9df03005f05c64433c @@ -0,0 +1,72 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17AFF431FC2 + for ; Mon, 12 May 2014 03:56:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hfUkIZz6dFtc for ; + Mon, 12 May 2014 03:56:09 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1210C431FC0 + for ; Mon, 12 May 2014 03:56:09 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1Wjnsd-0007DY-NO; Mon, 12 May 2014 10:54:47 +0000 +Received: (nullmailer pid 27461 invoked by uid 1000); Mon, 12 May 2014 + 10:54:28 -0000 +From: David Bremner +To: Charles Celerier , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h + with an underscore. +In-Reply-To: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu> +References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 12 May 2014 19:54:28 +0900 +Message-ID: <87d2fjgtcr.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 12 May 2014 10:56:17 -0000 + +Charles Celerier writes: + +> An underscore should precede every function name in +> lib/notmuch-private.h. This was not true and was noted by the failure of +> test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore +> before each function name in lib/notmuch-private.h where the underscore +> was missing and renames functions appropriately where they are used. + +Originally I thought this was uneccesarily intrusive, but on a second +look I see that there is only one symbol changed that doesn't start with +_notmuch, so I guess for consistency it's fine. + +I'm thinking about a 0.18.1 point release for build and portability +fixes; I do think this is a bit too much change for that (especially +since it doesn't actually fix the symbol hiding test (or more precisely, +your fix for OS/X breaks the linux test). + +d + +