From: Jani Nikula Date: Sun, 24 Aug 2014 12:56:04 +0000 (+0300) Subject: Re: [PATCH v3 03/13] new: Don't report version after upgrade X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1ee0e83e19f099ace73f90e3b5c6575f4e080298;p=notmuch-archives.git Re: [PATCH v3 03/13] new: Don't report version after upgrade --- diff --git a/d1/921ecd3cfa1baf72c263e1b559267491fdf6fc b/d1/921ecd3cfa1baf72c263e1b559267491fdf6fc new file mode 100644 index 000000000..a0310c7c6 --- /dev/null +++ b/d1/921ecd3cfa1baf72c263e1b559267491fdf6fc @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1D39E431FBC + for ; Sun, 24 Aug 2014 05:56:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id zcB4He8l5Eo8 for ; + Sun, 24 Aug 2014 05:56:09 -0700 (PDT) +Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com + [74.125.82.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 687B6431FAF for ; Sun, 24 Aug 2014 05:56:09 -0700 + (PDT) +Received: by mail-wg0-f43.google.com with SMTP id l18so12119616wgh.14 + for ; Sun, 24 Aug 2014 05:56:06 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=ZDdo6aLUhc+qJRdcLeVHBGPPV1pyE58/VkfdO3JXi1g=; + b=ML0NcYfat5Uvacl6J1znj8LHeYYHcuC9LWUndaf6jUTFG4Yih2pKEE4s0vhr8Mv13v + VcSa/OVYkJSAI/hmW8cdMefrSuoY1kZ7NJc6n5EJDsoFN0KJQuvuTU0qvwtCFM0dAXIZ + 5LszmEiHn49JExZrOATloeu9dpj6dKhvjp16mc9T5s/qpswskwZhSe1v1LyQRZDVwfl9 + yG0YezACeeI9Sfxw+M4qrFtOcELHN7pxL1aa7XhFfveMRbwdpziUjM4QsSYQ1bPkGg09 + nksYBr+SaZp5fsQUZ87OBtN4abqYg+8lBjlHYNeBGsNimGdGTmxtNnVLlKuiON8JR1UY + 5VAA== +X-Gm-Message-State: + ALoCoQlctJlXznXyUF4AX9jSSr9rcv2BQz9O5BCr9Nn8kUPPOTnB8/RWYwKv16iv0hiHcUqcEUEt +X-Received: by 10.180.186.98 with SMTP id fj2mr9174182wic.32.1408884966682; + Sun, 24 Aug 2014 05:56:06 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c374-75.dhcp.inet.fi. + [88.195.116.75]) by mx.google.com with ESMTPSA id + wi9sm91472460wjc.23.2014.08.24.05.56.05 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 24 Aug 2014 05:56:06 -0700 (PDT) +From: Jani Nikula +To: Austin Clements +Subject: Re: [PATCH v3 03/13] new: Don't report version after upgrade +In-Reply-To: <20140823225945.GL3015@mit.edu> +References: <1406859003-11561-1-git-send-email-amdragon@mit.edu> + <1406859003-11561-4-git-send-email-amdragon@mit.edu> + <87siknjjvm.fsf@nikula.org> <20140823225945.GL3015@mit.edu> +User-Agent: Notmuch/0.18.1+65~g9f0f30f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 24 Aug 2014 15:56:04 +0300 +Message-ID: <874mx2gi6z.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 24 Aug 2014 12:56:15 -0000 + +On Sun, 24 Aug 2014, Austin Clements wrote: +> Quoth Jani Nikula on Aug 23 at 6:39 pm: +>> On Fri, 01 Aug 2014, Austin Clements wrote: +>> > The version number has always been pretty meaningless to the user and +>> > it's about to become even more meaningless with the introduction of +>> > "features". Hopefully, the database will remain on version 3 for some +>> > time to come; however, the introduction of new features over time in +>> > version 3 will necessitate upgrades within version 3. It would be +>> > confusing if we always tell the user they've been "upgraded to version +>> > 3". If the user wants to know what's new, they should read the news. +>> +>> I think this is good for now. +>> +>> What do you think about adding notmuch_database_get_features(), and +>> printing that? +> +> Mark had a similar comment, so here's my reply: +> id:20140727162426.GF13893@mit.edu +> +> I'm happy with adding more transparency around this, though I'd prefer +> to do it as follow-up to avoid expanding this series and because I'm +> pretty sure adding something like notmuch_database_get_features +> wouldn't require any non-trivial changes to the stuff in this series. + +Agreed. + +BR, +Jani. +