From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 11 Feb 2016 07:16:59 +0000 (+0200)
Subject: Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1e73cd53c1ef2d650568841386c6e589a98fde7c;p=notmuch-archives.git

Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available
---

diff --git a/8e/c5c65137c013734b05d8f94fe39a1ea0e5e5f2 b/8e/c5c65137c013734b05d8f94fe39a1ea0e5e5f2
new file mode 100644
index 000000000..04c245812
--- /dev/null
+++ b/8e/c5c65137c013734b05d8f94fe39a1ea0e5e5f2
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 559686DE0BF6
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 23:16:50 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.642
+X-Spam-Level: 
+X-Spam-Status: No, score=0.642 tagged_above=-999 required=5 tests=[AWL=-0.010,
+  SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id SxnurhfVVeIB for <notmuch@notmuchmail.org>;
+ Wed, 10 Feb 2016 23:16:48 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id EF79F6DE0B36
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 23:16:47 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 16ACE10007F;
+ Thu, 11 Feb 2016 09:17:00 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available
+In-Reply-To: <874mdgo6za.fsf@alice.fifthhorseman.net>
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
+ <1454272801-23623-7-git-send-email-dkg@fifthhorseman.net>
+ <87lh6svl0b.fsf@maritornes.cs.unb.ca>
+ <874mdgo6za.fsf@alice.fifthhorseman.net>
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 11 Feb 2016 09:16:59 +0200
+Message-ID: <m237szk978.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 11 Feb 2016 07:16:50 -0000
+
+On Wed, Feb 10 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
+
+> On Wed 2016-02-10 06:54:12 -0500, David Bremner wrote:
+>> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+>>
+>>>  
+>>> +# choose the preferred GnuPG binary:
+>>> +if command -v gpg2 > /dev/null; then
+>>> +    GPG=gpg2
+>>> +else
+>>> +    GPG=gpg
+>>> +fi
+>>
+>> It feels like this should maybe be in configure, to centralize the choice
+>> of GPG default. At least, that would be consistent with python / python2
+>
+> I'm not sure what to do here.  Ultimately, i don't want there to be a
+> choice because i plan on having /usr/bin/gpg provided by gpg2, so this
+> will all be moot.
+
+Code searches through PATH, so IMO this test could do the same (with
+reasonable similarity (like above)). This could add check whether GPG
+is already defined that definition is used...
+
+
+>
+> So i'm not inclined to spend much more time/engineering effort on it,
+> but if someone wants to propose moving these choices into configure, i'd
+> be willing to review.
+>
+>    --dkg