From: David Bremner Date: Sat, 12 Mar 2016 16:26:45 +0000 (+2000) Subject: Re: [PATCH] use notmuch_database_open_verbose X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1de7a6085fe2c17bc4ad760c10987b5adb3ce931;p=notmuch-archives.git Re: [PATCH] use notmuch_database_open_verbose --- diff --git a/48/bd29c0acb2a98e97cae57e9a112b0bbb4a9e62 b/48/bd29c0acb2a98e97cae57e9a112b0bbb4a9e62 new file mode 100644 index 000000000..8a4a00160 --- /dev/null +++ b/48/bd29c0acb2a98e97cae57e9a112b0bbb4a9e62 @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 40AB46DE1867 + for ; Sat, 12 Mar 2016 08:26:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.031 +X-Spam-Level: +X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5 + tests=[AWL=-0.020, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GaVv7M2tK7dc for ; + Sat, 12 Mar 2016 08:26:49 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 5F20A6DE1865 + for ; Sat, 12 Mar 2016 08:26:49 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1aemNw-0007qq-Ba; Sat, 12 Mar 2016 11:27:24 -0500 +Received: (nullmailer pid 29846 invoked by uid 1000); + Sat, 12 Mar 2016 16:26:45 -0000 +From: David Bremner +To: Patrick Totzke , notmuch@notmuchmail.org +Subject: Re: [PATCH] use notmuch_database_open_verbose +In-Reply-To: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com> +References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com> +User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 12 Mar 2016 12:26:45 -0400 +Message-ID: <87r3ff64sa.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 12 Mar 2016 16:26:51 -0000 + +Patrick Totzke writes: + +> ... instead of the deprecated notmuch_database_open + +Perhaps it should be formally deprecated, but unlike several other +functions, it isn't. + +> when opening the database in notmuch.database.Database.open. +> This prevents the library to print Xapian exceptions to stderr. +> --- +> bindings/python/notmuch/database.py | 6 +++--- +> 1 file changed, 3 insertions(+), 3 deletions(-) +> +> diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py +> index f304533..5400338 100644 +> --- a/bindings/python/notmuch/database.py +> +++ b/bindings/python/notmuch/database.py +> @@ -86,8 +86,8 @@ class Database(object): +> _get_version.argtypes = [NotmuchDatabaseP] +> _get_version.restype = c_uint +> +> - """notmuch_database_open""" +> - _open = nmlib.notmuch_database_open +> + """notmuch_database_open_verbose""" +> + _open = nmlib.notmuch_database_open_verbose +> _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)] +> _open.restype = c_uint + +I expect you probably want to add the new binding, rather than replacing +the old one. Otherwise updating the bindings will break all bindings +using scripts. + +d