From: David Bremner Date: Tue, 4 Aug 2015 07:07:45 +0000 (+0200) Subject: Re: [PATCH 1/6] lib: Only sync modified message documents X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1ccce6696ef4f73cc236cb4c8d6dcf39bd16d33a;p=notmuch-archives.git Re: [PATCH 1/6] lib: Only sync modified message documents --- diff --git a/e3/afff675f6e3cc021c82c2bd1745ca813f31c17 b/e3/afff675f6e3cc021c82c2bd1745ca813f31c17 new file mode 100644 index 000000000..e44ee1a40 --- /dev/null +++ b/e3/afff675f6e3cc021c82c2bd1745ca813f31c17 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id DE07C6DE1343 + for ; Tue, 4 Aug 2015 00:08:33 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.513 +X-Spam-Level: +X-Spam-Status: No, score=0.513 tagged_above=-999 required=5 tests=[AWL=-0.231, + URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2S8Kp2GDMMiG for ; + Tue, 4 Aug 2015 00:08:32 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id EBBAE6DE133A + for ; Tue, 4 Aug 2015 00:08:31 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1ZMWKN-0000Vv-W6; Tue, 04 Aug 2015 07:08:00 +0000 +Received: (nullmailer pid 12036 invoked by uid 1000); Tue, 04 Aug 2015 + 07:07:45 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [PATCH 1/6] lib: Only sync modified message documents +In-Reply-To: <1433525318-23756-2-git-send-email-david@tethera.net> +References: <1432936375-astroid-4-0i1n6yczs2-1520@strange> + <1433525318-23756-1-git-send-email-david@tethera.net> + <1433525318-23756-2-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Tue, 04 Aug 2015 09:07:45 +0200 +Message-ID: <87h9ofo7jy.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Aug 2015 07:08:34 -0000 + +David Bremner writes: + +> From: Austin Clements +> +> Previously, we updated the database copy of a message on every call to +> _notmuch_message_sync, even if nothing had changed. In particular, +> this always happens on a thaw, so a freeze/thaw pair with no +> modifications between still caused a database update. +> +> We only modify message documents in a handful of places, so keep track +> of whether the document has been modified and only sync it when +> necessary. This will be particularly important when we add message +> revision tracking. + +This patch makes some sense without the rest of lastmod series, so I +merged it early to get some testing. + +d