From: David Bremner <david@tethera.net>
Date: Thu, 19 Nov 2015 11:57:11 +0000 (+2000)
Subject: Re: [PATCH 1/2] lib: content disposition values are not case-sensitive
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1c8be2f943c60e9f70ce0b97acdd6029b0527152;p=notmuch-archives.git

Re: [PATCH 1/2] lib: content disposition values are not case-sensitive
---

diff --git a/7c/12fe426e6c159cf975048686551be4538388b9 b/7c/12fe426e6c159cf975048686551be4538388b9
new file mode 100644
index 000000000..b72def0a8
--- /dev/null
+++ b/7c/12fe426e6c159cf975048686551be4538388b9
@@ -0,0 +1,64 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id D68406DE1A3F
+ for <notmuch@notmuchmail.org>; Thu, 19 Nov 2015 03:59:45 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.092
+X-Spam-Level: 
+X-Spam-Status: No, score=0.092 tagged_above=-999 required=5 tests=[AWL=0.092]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id gIJzTLlA2HXw for <notmuch@notmuchmail.org>;
+ Thu, 19 Nov 2015 03:59:44 -0800 (PST)
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 26D286DE19E7
+ for <notmuch@notmuchmail.org>; Thu, 19 Nov 2015 03:59:44 -0800 (PST)
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
+ (envelope-from <david@tethera.net>)
+ id 1ZzNqF-0003xq-7R; Thu, 19 Nov 2015 11:57:31 +0000
+Received: (nullmailer pid 29368 invoked by uid 1000); Thu, 19 Nov 2015
+ 11:57:11 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, Johannes Schauer <josch@debian.org>,
+ notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/2] lib: content disposition values are not
+ case-sensitive
+In-Reply-To: <1443260122-5122-1-git-send-email-jani@nikula.org>
+References: <871tdvvoyf.fsf@tesseract.cs.unb.ca>
+ <1443260122-5122-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Thu, 19 Nov 2015 07:57:11 -0400
+Message-ID: <87610yp5go.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 19 Nov 2015 11:59:46 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> Per RFC 2183, the values for Content-Disposition values are not
+> case-sensitive. While at it, use the gmime function for getting at the
+> disposition string instead of referencing the field directly.
+
+I pushed these two, along with the working test from my patch.
+
+If someone actually has a fix for the other test, we can return to
+discussing whether it's a bug or not.
+
+d