From: Daniel Kahn Gillmor Date: Sat, 9 Apr 2016 01:54:51 +0000 (+2100) Subject: [PATCH v4 6/7] On deletion, replace with ghost when other active messages in thread X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1c67b3b83caed09b09aed624b96a1a7089cc3994;p=notmuch-archives.git [PATCH v4 6/7] On deletion, replace with ghost when other active messages in thread --- diff --git a/78/913af1eb29ade64eef30043ee658d993269da8 b/78/913af1eb29ade64eef30043ee658d993269da8 new file mode 100644 index 000000000..266516b9f --- /dev/null +++ b/78/913af1eb29ade64eef30043ee658d993269da8 @@ -0,0 +1,141 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 768DE6DE092B + for ; Fri, 8 Apr 2016 18:55:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1mqU_sJPVnX8 for ; + Fri, 8 Apr 2016 18:55:40 -0700 (PDT) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id A25286DE0352 + for ; Fri, 8 Apr 2016 18:55:14 -0700 (PDT) +Received: from fifthhorseman.net (unknown [201.140.212.132]) + by che.mayfirst.org (Postfix) with ESMTPSA id ED6F710070 + for ; Fri, 8 Apr 2016 21:55:12 -0400 (EDT) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id 5D99720555; Fri, 8 Apr 2016 22:54:52 -0300 (ART) +From: Daniel Kahn Gillmor +To: Notmuch Mail +Subject: [PATCH v4 6/7] On deletion, + replace with ghost when other active messages in thread +Date: Fri, 8 Apr 2016 22:54:51 -0300 +Message-Id: <1460166892-29721-6-git-send-email-dkg@fifthhorseman.net> +X-Mailer: git-send-email 2.8.0.rc3 +In-Reply-To: <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> +References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 09 Apr 2016 01:55:48 -0000 + +There is no need to add a ghost message upon deletion if there are no +other active messages in the thread. + +Also, if the message being deleted was a ghost already, we can just go +ahead and delete it. +--- + lib/message.cc | 58 ++++++++++++++++++++++++++++++++++++++++++---------------- + 1 file changed, 42 insertions(+), 16 deletions(-) + +diff --git a/lib/message.cc b/lib/message.cc +index 2399ab3..1b423b0 100644 +--- a/lib/message.cc ++++ b/lib/message.cc +@@ -1044,11 +1044,14 @@ _notmuch_message_delete (notmuch_message_t *message) + { + notmuch_status_t status; + Xapian::WritableDatabase *db; +- const char *mid, *tid; ++ const char *mid, *tid, *query_string; + notmuch_message_t *ghost; + notmuch_private_status_t private_status; + notmuch_database_t *notmuch; +- ++ notmuch_query_t *query; ++ unsigned int count = 0; ++ notmuch_bool_t is_ghost; ++ + mid = notmuch_message_get_message_id (message); + tid = notmuch_message_get_thread_id (message); + notmuch = message->notmuch; +@@ -1059,22 +1062,45 @@ _notmuch_message_delete (notmuch_message_t *message) + + db = static_cast (notmuch->xapian_db); + db->delete_document (message->doc_id); +- +- /* and reintroduce a ghost in its place */ +- ghost = _notmuch_message_create_for_message_id (notmuch, mid, &private_status); +- if (private_status == NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND) { +- private_status = _notmuch_message_initialize_ghost (ghost, tid); +- if (! private_status) +- _notmuch_message_sync (ghost); +- } else if (private_status == NOTMUCH_PRIVATE_STATUS_SUCCESS) { +- /* this is deeply weird, and we should not have gotten into +- this state. is there a better error message to return +- here? */ +- return NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID; ++ ++ /* if this was a ghost to begin with, we are done */ ++ private_status = _notmuch_message_has_term (message, "type", "ghost", &is_ghost); ++ if (private_status) ++ return COERCE_STATUS (private_status, ++ "Error trying to determine whether message was a ghost"); ++ if (is_ghost) ++ return NOTMUCH_STATUS_SUCCESS; ++ ++ query_string = talloc_asprintf (message, "thread:%s", tid); ++ query = notmuch_query_create (notmuch, query_string); ++ if (query == NULL) ++ return NOTMUCH_STATUS_OUT_OF_MEMORY; ++ status = notmuch_query_count_messages_st (query, &count); ++ if (status) { ++ notmuch_query_destroy (query); ++ return status; + } + +- notmuch_message_destroy (ghost); +- return COERCE_STATUS (private_status, "Error converting to ghost message"); ++ if (count > 0) { ++ /* reintroduce a ghost in its place because there are still ++ * other active messages in this thread: */ ++ ghost = _notmuch_message_create_for_message_id (notmuch, mid, &private_status); ++ if (private_status == NOTMUCH_PRIVATE_STATUS_NO_DOCUMENT_FOUND) { ++ private_status = _notmuch_message_initialize_ghost (ghost, tid); ++ if (! private_status) ++ _notmuch_message_sync (ghost); ++ } else if (private_status == NOTMUCH_PRIVATE_STATUS_SUCCESS) { ++ /* this is deeply weird, and we should not have gotten ++ into this state. is there a better error message to ++ return here? */ ++ status = NOTMUCH_STATUS_DUPLICATE_MESSAGE_ID; ++ } ++ ++ notmuch_message_destroy (ghost); ++ status = COERCE_STATUS (private_status, "Error converting to ghost message"); ++ } ++ notmuch_query_destroy (query); ++ return status; + } + + /* Transform a blank message into a ghost message. The caller must +-- +2.8.0.rc3 +