From: Robin H. Johnson <robbat2@gentoo.org>
Date: Sat, 7 Mar 2020 19:54:46 +0000 (-0800)
Subject: go-module: workaround MissingUnpackerDep QA false positive
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1b302a4d9361b070f0ace9547b1faa5b0cf5da89;p=gentoo.git

go-module: workaround MissingUnpackerDep QA false positive

The go.sum behavior in this eclass triggers a false positive from
pkgcheck, specifically:
MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"

The eclass & package do NOT invoke any direct unpacking of the zipfiles,
and leave that entirely to Go's builtin code, making app-arch/unzip
completely unneeded.

Adding packages using the new eclass functionality will spam the above
MissingUnpackerDep warning, so workaround it for now, until pkgcheck/QA
can not give the false positive.

Reference: https://github.com/pkgcore/pkgcheck/issues/214
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
---

diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
index 08c123873c47..cdd5b07a930f 100644
--- a/eclass/go-module.eclass
+++ b/eclass/go-module.eclass
@@ -57,6 +57,12 @@ _GO_MODULE=1
 
 BDEPEND=">=dev-lang/go-1.12"
 
+# Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
+# MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
+# Added here rather than to each affected package, so it can be cleaned up just
+# once when pkgcheck is improved.
+BDEPEND+=" app-arch/unzip"
+
 # Force go to build in module mode.
 # In this mode the GOPATH environment variable is ignored.
 # this will become the default in the future.