From: Tomi Ollila Date: Wed, 30 Sep 2015 06:13:30 +0000 (+0300) Subject: Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1a802521b2a09051c312be20419fea6e9d9e8d63;p=notmuch-archives.git Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client --- diff --git a/1c/6b5a1be9191ad5a1f4d19b5354f04f02db75ef b/1c/6b5a1be9191ad5a1f4d19b5354f04f02db75ef new file mode 100644 index 000000000..60885dd6c --- /dev/null +++ b/1c/6b5a1be9191ad5a1f4d19b5354f04f02db75ef @@ -0,0 +1,143 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 02FCA6DE17FE + for ; Tue, 29 Sep 2015 23:13:32 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.15 +X-Spam-Level: * +X-Spam-Status: No, score=1.15 tagged_above=-999 required=5 tests=[AWL=-0.246, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KwITHwJnlZRf for ; + Tue, 29 Sep 2015 23:13:29 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 5764A6DE17FD + for ; Tue, 29 Sep 2015 23:13:28 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 56AAE100080; + Wed, 30 Sep 2015 09:13:30 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by + default with --client +In-Reply-To: +References: + <455026447d3f75b1038ac11cebe734431604be9d.1439629384.git.jani@nikula.org> + <87wpva3j37.fsf@zancas.localnet> + +User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 30 Sep 2015 06:13:32 -0000 + +On Tue, Sep 29 2015, Tomi Ollila wrote: + +> On Mon, Sep 28 2015, David Bremner wrote: +> +>> Tomi Ollila writes: +>> +>> +>>> if [ -n "$AUTO_DAEMON" -a -z "$CREATE_FRAME" ]; then +>>> echo "$0: --auto-daemon is only applicable with --create-frame." >&2 +>>> exit 1 +>>> fi +>>> +>>> without this one may execute ./notmuch-emacs-mua --client --auto-daemon +>>> which yields starting emacs in daemon mode (in this example it is expected +>>> emacs is not running; otherwise --auto-daemon has no use in this example) +>>> -- but no ui to that newly-running emacs is provided. Similar behaviour +>>> can be observed by the following +>>> +>> +>> I think what you propose is fine for a followup patch; note that the +>> scenario you worry about also needs --client to be a problem. Apparently +>> nothing is uncontroversial here, but if auto-daemon only works with +>> create frame, then perhaps the followup would be to have auto-daemon +>> imply create-frame +> +> Without --client --auto-daemon is no-op (as it is no-op in case emacs +> server is already running). I am (only) concerned about user experience +> when one runs --client --auto-daemon and user gets nothing (i.e. emacs +> server is running in the background w/o any clients connected to it. +> +> We could make --auto-daemon imply --create-frame, but then +> +> ./notmuch-emacs-mua --auto-daemon (i.e. w/o --client) starts new mail +> compose window to separate frame (even though user did not request +> it w/ --create-frame) + +Hmm, a few more tests. it now looks like in case the command line is + +./notmuch-emacs-mua --client --auto-daemon + +Then the --create-frame should be implied. w/o --client --create-frame +would ... well, create that (only) emacs frame anyways... oh, the +combinations; for reference I just paste from my history... + + + 1 07:57 0:01 ccd notmuch + 2 07:57 0:06 git pull --rebase + 3 07:57 0:01 git log + 4 07:57 0:04 tig + 5 07:58 0:10 ./notmuch-emacs-mua --auto-daemon + 6 07:58 0:00 ps ax + 8 07:58 0:00 emacs & + 9 07:58 0:07 ./notmuch-emacs-mua --auto-daemon + 10 07:59 0:01 ./notmuch-emacs-mua --client --auto-daemon + 12 08:01 0:03 ./notmuch-emacs-mua --auto-daemon + 13 08:02 0:00 ps ax + 14 08:02 0:00 ls /tmp/emacs1001 + 15 08:02 0:00 ./notmuch-emacs-mua -nw --auto-daemon + 16 08:02 0:04 DISPLAY= ./notmuch-emacs-mua --auto-daemon + 17 08:02 0:05 tig + 18 08:03 0:02 DISPLAY= ./notmuch-emacs-mua --auto-daemon + 19 08:04 0:01 DISPLAY= ./notmuch-emacs-mua --client --auto-daemon + 20 08:04 0:00 ps ax + 21 08:04 0:00 kill 1860 + 22 08:04 0:00 ps ax + 23 08:06 0:00 ./notmuch-emacs-mua --client --auto-daemon + 24 08:06 0:00 ps ax + 25 08:06 0:00 kill 1875 + 26 08:06 0:00 ./notmuch-emacs-mua --client --auto-daemon + 27 08:06 0:00 ps ax + 28 08:06 0:00 kill 1926 + 29 08:06 0:06 ./notmuch-emacs-mua --client --auto-daemon --create-frame + 30 08:07 0:28 ./notmuch-emacs-mua --auto-daemon --create-frame + 31 08:08 0:00 ps x + 32 08:08 0:00 h + +So. I'm going w/ the suggestion making --auto-daemon imply --create-frame + + +> +> (actually I already did the 'imply' option (easy, one line in script, +> another in namual), just that testing it gave this thought... +> +> ... therefore I'd rather make ./notmuch-emacs-mua --auto-daemon +> spit an error and exit -- but I can be convinced otherwise :) +> +> Tomi