From: Jameson Graef Rollins Date: Mon, 14 Apr 2014 19:40:50 +0000 (+1700) Subject: [PATCH] emacs: remove auto-signing of replies to signed messages X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1a70b3b8bc0f14043e13bbfe78ac753789d6e440;p=notmuch-archives.git [PATCH] emacs: remove auto-signing of replies to signed messages --- diff --git a/79/b486ff2164dc6abb0298fa89028133f4465bc7 b/79/b486ff2164dc6abb0298fa89028133f4465bc7 new file mode 100644 index 000000000..f8acfe4b8 --- /dev/null +++ b/79/b486ff2164dc6abb0298fa89028133f4465bc7 @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 13648431FC3 + for ; Mon, 14 Apr 2014 12:40:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yMudU-WPcgSA for ; + Mon, 14 Apr 2014 12:40:52 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 40010431FC0 + for ; Mon, 14 Apr 2014 12:40:52 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id DE03A32824B + for ; Mon, 14 Apr 2014 12:40:51 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (cpe-107-185-189-81.socal.res.rr.com + [107.185.189.81]) (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id 98FE0328274 + for ; Mon, 14 Apr 2014 12:40:50 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 56CBC60123; Mon, 14 Apr 2014 12:40:50 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: [PATCH] emacs: remove auto-signing of replies to signed messages +Date: Mon, 14 Apr 2014 12:40:50 -0700 +Message-Id: <1397504450-15498-1-git-send-email-jrollins@finestructure.net> +X-Mailer: git-send-email 1.9.1 +In-Reply-To: <87mwfnd9eh.fsf@tethera.net> +References: <87mwfnd9eh.fsf@tethera.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 14 Apr 2014 19:40:56 -0000 + +It was decided that auto-signing is potentially too troublesome for the +apparently common case of users who enable crypto processing for the +purpose of checking signature validity but who are not in a position to +sign out-going messages. Users can still manually invoke signing as needed. + +Encrypting replies to encrypted messages is more of a security issue +so we leave it in place. +--- + emacs/notmuch-mua.el | 7 +++---- + 1 file changed, 3 insertions(+), 4 deletions(-) + +diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +index bf6253f..95e4a4d 100644 +--- a/emacs/notmuch-mua.el ++++ b/emacs/notmuch-mua.el +@@ -116,10 +116,9 @@ list." + notmuch-mua-hidden-headers)) + + (defun notmuch-mua-reply-crypto (parts) ++ "Add mml sign-encrypt flag if any part of original message is encrypted." + (loop for part in parts +- if (notmuch-match-content-type (plist-get part :content-type) "multipart/signed") +- do (mml-secure-message-sign) +- else if (notmuch-match-content-type (plist-get part :content-type) "multipart/encrypted") ++ if (notmuch-match-content-type (plist-get part :content-type) "multipart/encrypted") + do (mml-secure-message-sign-encrypt) + else if (notmuch-match-content-type (plist-get part :content-type) "multipart/*") + do (notmuch-mua-reply-crypto (plist-get part :content)))) +@@ -236,7 +235,7 @@ list." + ;; Quote the original message according to the user's configured style. + (message-cite-original))) + +- ;; Sign and/or encrypt replies to signed and/or encrypted messages. ++ ;; Crypto processing based crypto content of the original message + (when process-crypto + (notmuch-mua-reply-crypto (plist-get original :body)))) + +-- +1.9.1 +