From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 27 Apr 2013 09:39:17 +0000 (+0300)
Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=192c766d897a5a28ce9ba9fe29b7ef0e587ee0d4;p=notmuch-archives.git

Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
---

diff --git a/92/59a54e14b7e6e32901a05c38f1d227a929447b b/92/59a54e14b7e6e32901a05c38f1d227a929447b
new file mode 100644
index 000000000..fd1a91c00
--- /dev/null
+++ b/92/59a54e14b7e6e32901a05c38f1d227a929447b
@@ -0,0 +1,79 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 3B2A3431FBD
+	for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 02:39:19 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id X9c7nBN3Ylz3 for <notmuch@notmuchmail.org>;
+	Sat, 27 Apr 2013 02:39:18 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 9668D431FAF
+	for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 02:39:18 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 929FA1001F0;
+	Sat, 27 Apr 2013 12:39:17 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>,
+ Mark Walters <markwalters1009@gmail.com>,	notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
+In-Reply-To: <87mwt2ve95.fsf@zancas.localnet>
+References: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi>
+	<87eheekjgp.fsf@qmul.ac.uk> <87mwt2ve95.fsf@zancas.localnet>
+User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 27 Apr 2013 12:39:17 +0300
+Message-ID: <m2ehdwz516.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 27 Apr 2013 09:39:19 -0000
+
+On Sat, Apr 13 2013, David Bremner <david@tethera.net> wrote:
+
+> Mark Walters <markwalters1009@gmail.com> writes:
+>
+>> On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
+>>> Some (declare-function ...) definitions were drifted away from the
+>>> actual (defun ...)'s. To find the drifts and to verify changes
+>>> the following command line was used:
+>>>
+>>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
+>>
+>> This patch looks good to me +1.
+>>
+>> Is it worth making the above command into a test?
+
+I attempted to do a test -- failed miserably with test_emacs ()
+
+> Maybe a release check?
+
+You want to delegate the work developers should do to yourself
+(if not fixing the things, moan about those ;)
+
+For the time being I drop needs-review tag.
+
+> d
+
+Tomi