From: Tom Yu Date: Wed, 15 Apr 2009 21:00:24 +0000 (+0000) Subject: fcc_generate_new destroys locked mutex on error X-Git-Tag: krb5-1.7-beta1~8 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1915f27b7d730fe540ac5d2ed8c4b00b20d217fc;p=krb5.git fcc_generate_new destroys locked mutex on error pull up r22200 from trunk ------------------------------------------------------------------------ r22200 | ghudson | 2009-04-13 15:29:14 -0400 (Mon, 13 Apr 2009) | 3 lines Changed paths: M /trunk/src/lib/krb5/ccache/cc_file.c krb5_fcc_generate_new was destroying a locked mutex in the err_out label, which is used for I/O failures. Unlock the mutex first. ticket: 6469 tags: pullup target_version: 1.7 version_fixed: 1.7 git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@22259 dc483132-0cff-0310-8789-dd5450dbe970 --- diff --git a/src/lib/krb5/ccache/cc_file.c b/src/lib/krb5/ccache/cc_file.c index 9e54d1bdd..23ece3e12 100644 --- a/src/lib/krb5/ccache/cc_file.c +++ b/src/lib/krb5/ccache/cc_file.c @@ -2129,6 +2129,7 @@ krb5_fcc_generate_new (krb5_context context, krb5_ccache *id) err_out: k5_cc_mutex_unlock(context, &krb5int_cc_file_mutex); + k5_cc_mutex_unlock(context, &data->lock); k5_cc_mutex_destroy(&data->lock); free(data->filename); free(data);