From: David Bremner <david@tethera.net>
Date: Sun, 13 Jul 2014 15:43:55 +0000 (+2100)
Subject: Re: [PATCH v2] lib: Start all function names in notmuch-private.h with
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1903509b2215fc3fdc6044bc324de20f17193fc6;p=notmuch-archives.git

Re: [PATCH v2] lib: Start all function names in notmuch-private.h with
---

diff --git a/2a/f42d3a433b61aae00c1e8b9cf58063a7ff430b b/2a/f42d3a433b61aae00c1e8b9cf58063a7ff430b
new file mode 100644
index 000000000..f340d7e62
--- /dev/null
+++ b/2a/f42d3a433b61aae00c1e8b9cf58063a7ff430b
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1FC1B431FBD
+	for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 08:44:07 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id umSiob94r6y6 for <notmuch@notmuchmail.org>;
+	Sun, 13 Jul 2014 08:43:59 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id A5C74431FBC
+	for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 08:43:59 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1X6LwU-0007a1-Vc; Sun, 13 Jul 2014 12:43:58 -0300
+Received: (nullmailer pid 24895 invoked by uid 1000); Sun, 13 Jul 2014
+	15:43:55 -0000
+From: David Bremner <david@tethera.net>
+To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2] lib: Start all function names in notmuch-private.h
+ with
+In-Reply-To: <1399974245-77744-1-git-send-email-cceleri@cs.stanford.edu>
+References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>
+	<1399974245-77744-1-git-send-email-cceleri@cs.stanford.edu>
+User-Agent: Notmuch/0.18.1+29~gb5327d4 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 13 Jul 2014 12:43:55 -0300
+Message-ID: <87wqbhe01w.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 13 Jul 2014 15:44:07 -0000
+
+Charles Celerier <cceleri@cs.stanford.edu> writes:
+
+> As noted in devel/STYLE, every private library function should start
+> with _notmuch. This patch corrects function naming that did not adhere
+> to this style in lib/notmuch-private.h. In particular, the old function
+> names that now begin with _notmuch are
+>
+>     notmuch_sha1_of_file
+>     notmuch_sha1_of_string
+>     notmuch_message_file_close
+>     notmuch_message_file_get_header
+>     notmuch_message_file_open
+>     notmuch_message_get_author
+>     notmuch_message_set_author
+>
+
+finally pushed,
+
+d