From: Ken Raeburn <raeburn@mit.edu>
Date: Thu, 5 Feb 2009 01:49:21 +0000 (+0000)
Subject: int/ptr bug in gssapi code
X-Git-Tag: krb5-1.8-alpha1~717
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1705970a5aebaeb693fb5e074a7948ac4b03f7ef;p=krb5.git

int/ptr bug in gssapi code

Fix a pointer argument passed where an integer is needed.
Update Sun compiler options to make that an error.  (The options we're
currently using make it an error for assignment but not for argument passing.)

ticket: 6363
target_version: 1.7
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21887 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/aclocal.m4 b/src/aclocal.m4
index c494750ad..4f1c9d6e2 100644
--- a/src/aclocal.m4
+++ b/src/aclocal.m4
@@ -664,7 +664,7 @@ else
     # works, but it also means that declaration-in-code warnings won't
     # be issued.
     # -v -fd -errwarn=E_DECLARATION_IN_CODE ...
-    WARN_CFLAGS="-errtags=yes -errwarn=E_BAD_PTR_INT_COMBINATION -errwarn=E_PTR_TO_VOID_IN_ARITHMETIC"
+    WARN_CFLAGS="-errtags=yes -errwarn=E_BAD_PTR_INT_COMBINATION -errwarn=E_BAD_PTR_INT_COMB_ARG -errwarn=E_PTR_TO_VOID_IN_ARITHMETIC"
     WARN_CXXFLAGS="-errtags=yes +w +w2 -xport64"
   fi
 fi
diff --git a/src/lib/gssapi/krb5/k5seal.c b/src/lib/gssapi/krb5/k5seal.c
index bff1ab185..1949020ab 100644
--- a/src/lib/gssapi/krb5/k5seal.c
+++ b/src/lib/gssapi/krb5/k5seal.c
@@ -258,7 +258,7 @@ make_seal_token_v1 (krb5_context context,
             unsigned char bigend_seqnum[4];
             krb5_keyblock *enc_key;
             int i;
-            store_32_be(seqnum, bigend_seqnum);
+            store_32_be(*seqnum, bigend_seqnum);
             code = krb5_copy_keyblock (context, enc, &enc_key);
             if (code)
             {