From: Jani Nikula Date: Wed, 11 Sep 2013 17:40:40 +0000 (+0300) Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1678784467ad39902013459487ad336abc4fa4ba;p=notmuch-archives.git Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init() --- diff --git a/c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d b/c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d new file mode 100644 index 000000000..3b9728d34 --- /dev/null +++ b/c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 13C36431FAF + for ; Wed, 11 Sep 2013 10:40:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id H-+Y40agq3vZ for ; + Wed, 11 Sep 2013 10:40:42 -0700 (PDT) +Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com + [209.85.215.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B85E2431FAE + for ; Wed, 11 Sep 2013 10:40:41 -0700 (PDT) +Received: by mail-ea0-f179.google.com with SMTP id b10so4748694eae.38 + for ; Wed, 11 Sep 2013 10:40:40 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=OzoFLp4k296bUnYpJLWXSi47o9GRucF/CHjQyA0spC0=; + b=Ynxye6f1fngtEHvPT5mBb6JeRwsiLFPVHD43Tl7hFUxqYjmaTtIJOTHNzpYCRmbNYn + HKAdBhWajCmkGP3RPisbmjHQZUQ1ydnZMJ6QJoV5bss3ETvXNL6fqY2M2z97/mTTNz+N + 3TcA40vN8YRNgAuDqN83OTB77tJhUuIE9Y8I8CgK1HDx7RGX4o4Se+ni+/LXYUHmCZyX + CndPMDYXqPneCDndPyF5tgjJHaOjGB4fmAA3t28wr+iL6XD2SFRC9XpTftR6xHn7C2mL + WS1koRPYbbxNRM5noEBYGevxMLDvPQ7JBwSE0Qg9zwsh+Rkcf6HwZXuRAhueCbEDR77X + fWig== +X-Gm-Message-State: + ALoCoQnq80MzzB0EYLoS0AQCa0MOLOCtxz5SBLOoAyHxsrJr/Y7YLh7uVqn8D8qsv7sCBv0RCcvw +X-Received: by 10.14.8.72 with SMTP id 48mr3927478eeq.25.1378921240464; + Wed, 11 Sep 2013 10:40:40 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) + by mx.google.com with ESMTPSA id a43sm42119643eep.9.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Wed, 11 Sep 2013 10:40:39 -0700 (PDT) +From: Jani Nikula +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to + g_mime_init() +In-Reply-To: <8738pcjet4.fsf@awakening.csail.mit.edu> +References: <1378839078-6298-1-git-send-email-jani@nikula.org> + <8738pcjet4.fsf@awakening.csail.mit.edu> +User-Agent: Notmuch/0.16+74~g35e4af5 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 11 Sep 2013 20:40:40 +0300 +Message-ID: <87vc27p887.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 11 Sep 2013 17:40:48 -0000 + +On Wed, 11 Sep 2013, Austin Clements wrote: +> LGTM in principle, though I'd like to see a test of some of the +> malformed RFC 2047 that this lets us decode. Is there a summary +> somewhere of exactly what these workarounds enable? + +Not that I know of; looking into gmime source it's mostly about encoded +words without surrounding space, or space within encoded words. + +v2 now has known broken tests for known broken encodings... + +> This isn't directly related to this patch, but is there a reason we +> g_mime_init in so many different places? Both the CLI and +> notmuch_database_open I can understand because the CLI also uses GMime +> and should be sure it's initialized. Maaaybe +> notmuch_message_file_get_header because notmuch_message_file +> theoretically independent of the database, even though I don't think +> it's possible to call into it without first calling +> notmuch_database_open. But _notmuch_message_index_file? + +I noted the same, but decided it's another patch, another time. + + +BR, +Jani.