From: Daniel Kahn Gillmor Date: Sat, 9 Apr 2016 01:54:49 +0000 (+2100) Subject: [PATCH v4 4/7] Add internal functions to search for alternate doc types X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=15e0b8f378caa22d7c7980c0fbcfaae5ac5e672d;p=notmuch-archives.git [PATCH v4 4/7] Add internal functions to search for alternate doc types --- diff --git a/bc/d27ede7a0dad23b814f59ea4f3107825bbde6e b/bc/d27ede7a0dad23b814f59ea4f3107825bbde6e new file mode 100644 index 000000000..a0f0a02af --- /dev/null +++ b/bc/d27ede7a0dad23b814f59ea4f3107825bbde6e @@ -0,0 +1,134 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id B77D56DE02DB + for ; Fri, 8 Apr 2016 18:55:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5x3cfAf7VKwl for ; + Fri, 8 Apr 2016 18:55:23 -0700 (PDT) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id 15DCE6DE0317 + for ; Fri, 8 Apr 2016 18:55:08 -0700 (PDT) +Received: from fifthhorseman.net (unknown [201.140.212.132]) + by che.mayfirst.org (Postfix) with ESMTPSA id 2673F1006F + for ; Fri, 8 Apr 2016 21:55:06 -0400 (EDT) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id 545CC200E0; Fri, 8 Apr 2016 22:54:52 -0300 (ART) +From: Daniel Kahn Gillmor +To: Notmuch Mail +Subject: [PATCH v4 4/7] Add internal functions to search for alternate doc + types +Date: Fri, 8 Apr 2016 22:54:49 -0300 +Message-Id: <1460166892-29721-4-git-send-email-dkg@fifthhorseman.net> +X-Mailer: git-send-email 2.8.0.rc3 +In-Reply-To: <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> +References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 09 Apr 2016 01:55:31 -0000 + +Publicly we are only exposing the non-ghost documents (of "type" +"mail"). But internally we might want to inspect the ghost messages +as well. + +This changeset adds two new private interfaces to queries to recover +information about alternate document types. +--- + lib/notmuch-private.h | 11 +++++++++++ + lib/query.cc | 18 ++++++++++++++++-- + 2 files changed, 27 insertions(+), 2 deletions(-) + +diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h +index 5dd4770..d95bf31 100644 +--- a/lib/notmuch-private.h ++++ b/lib/notmuch-private.h +@@ -477,6 +477,17 @@ void + _notmuch_doc_id_set_remove (notmuch_doc_id_set_t *doc_ids, + unsigned int doc_id); + ++/* querying xapian documents by type (e.g. "mail" or "ghost"): */ ++notmuch_status_t ++_notmuch_query_search_documents (notmuch_query_t *query, ++ const char *type, ++ notmuch_messages_t **out); ++ ++notmuch_status_t ++_notmuch_query_count_documents (notmuch_query_t *query, ++ const char *type, ++ unsigned *count_out); ++ + /* message.cc */ + + void +diff --git a/lib/query.cc b/lib/query.cc +index e627bfc..77a7926 100644 +--- a/lib/query.cc ++++ b/lib/query.cc +@@ -187,6 +187,14 @@ notmuch_status_t + notmuch_query_search_messages_st (notmuch_query_t *query, + notmuch_messages_t **out) + { ++ return _notmuch_query_search_documents (query, "mail", out); ++} ++ ++notmuch_status_t ++_notmuch_query_search_documents (notmuch_query_t *query, ++ const char *type, ++ notmuch_messages_t **out) ++{ + notmuch_database_t *notmuch = query->notmuch; + const char *query_string = query->query_string; + notmuch_mset_messages_t *messages; +@@ -208,7 +216,7 @@ notmuch_query_search_messages_st (notmuch_query_t *query, + Xapian::Enquire enquire (*notmuch->xapian_db); + Xapian::Query mail_query (talloc_asprintf (query, "%s%s", + _find_prefix ("type"), +- "mail")); ++ type)); + Xapian::Query string_query, final_query, exclude_query; + Xapian::MSet mset; + Xapian::MSetIterator iterator; +@@ -554,6 +562,12 @@ notmuch_query_count_messages (notmuch_query_t *query) + notmuch_status_t + notmuch_query_count_messages_st (notmuch_query_t *query, unsigned *count_out) + { ++ return _notmuch_query_count_documents (query, "mail", count_out); ++} ++ ++notmuch_status_t ++_notmuch_query_count_documents (notmuch_query_t *query, const char *type, unsigned *count_out) ++{ + notmuch_database_t *notmuch = query->notmuch; + const char *query_string = query->query_string; + Xapian::doccount count = 0; +@@ -562,7 +576,7 @@ notmuch_query_count_messages_st (notmuch_query_t *query, unsigned *count_out) + Xapian::Enquire enquire (*notmuch->xapian_db); + Xapian::Query mail_query (talloc_asprintf (query, "%s%s", + _find_prefix ("type"), +- "mail")); ++ type)); + Xapian::Query string_query, final_query, exclude_query; + Xapian::MSet mset; + unsigned int flags = (Xapian::QueryParser::FLAG_BOOLEAN | +-- +2.8.0.rc3 +