From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 19 Nov 2014 11:06:50 +0000 (+0200)
Subject: Re: [PATCH v1] emacs: `with-current-notmuch-show-message' should not leak	`coding... 
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=151c4a67fa45073c276877add17c149861b676a5;p=notmuch-archives.git

Re: [PATCH v1] emacs: `with-current-notmuch-show-message' should not leak	`coding-system-for-read'
---

diff --git a/20/20816f8978ef928cfddffe2cccaa0c6592fba6 b/20/20816f8978ef928cfddffe2cccaa0c6592fba6
new file mode 100644
index 000000000..701fdd5a7
--- /dev/null
+++ b/20/20816f8978ef928cfddffe2cccaa0c6592fba6
@@ -0,0 +1,101 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 8E8DF431FAF
+	for <notmuch@notmuchmail.org>; Wed, 19 Nov 2014 03:07:13 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id DN-ljETRdh+D for <notmuch@notmuchmail.org>;
+	Wed, 19 Nov 2014 03:07:05 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 828E4431FAE
+	for <notmuch@notmuchmail.org>; Wed, 19 Nov 2014 03:07:05 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 169BD1000C1;
+	Wed, 19 Nov 2014 13:06:51 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v1] emacs: `with-current-notmuch-show-message' should not
+	leak	`coding-system-for-read'
+In-Reply-To: <1416294197-3170-1-git-send-email-dme@dme.org>
+References: <1416294197-3170-1-git-send-email-dme@dme.org>
+User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 19 Nov 2014 13:06:50 +0200
+Message-ID: <m2389fsb3p.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 19 Nov 2014 11:07:13 -0000
+
+On Tue, Nov 18 2014, David Edmondson <dme@dme.org> wrote:
+
+> `with-current-notmuch-show-message' applies a `no-conversion' coding
+> system when reading a raw message from notmuch. That coding system
+> should _not_ be applied when the body of the macro is evaluated, as it
+> can cause file operations used during that evaluation to incorrectly
+> apply the `no-conversion' coding system.
+>
+> This was discovered when a user's .signature file contained non-ASCII
+> characters. When a message is forwarded, the `no-conversion' coding
+> system was applied to the reading of the .signature file, resulting in
+> raw rather than UTF-8 interpretation of the data.
+> ---
+
+Uh, this looks as good as it can be ;), and tests pass, +1
+
+Tomi
+
+
+
+>
+> Fix for id:87ioifb55d.fsf@nautilus.nautilus.
+>
+>  emacs/notmuch-show.el | 6 +++---
+>  1 file changed, 3 insertions(+), 3 deletions(-)
+>
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
+> index 4035fe8..b8cfbb8 100644
+> --- a/emacs/notmuch-show.el
+> +++ b/emacs/notmuch-show.el
+> @@ -241,9 +241,9 @@ every user interaction with notmuch."
+>         (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))
+>           (with-current-buffer buf
+>  	   (let ((coding-system-for-read 'no-conversion))
+> -	     (call-process notmuch-command nil t nil "show" "--format=raw" id)
+> -	     ,@body)
+> -	   (kill-buffer buf))))))
+> +	     (call-process notmuch-command nil t nil "show" "--format=raw" id))
+> +	   ,@body)
+> +	 (kill-buffer buf)))))
+>  
+>  (defun notmuch-show-turn-on-visual-line-mode ()
+>    "Enable Visual Line mode."
+> -- 
+> 2.1.3
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch