From: Felipe Contreras Date: Thu, 22 May 2014 08:15:58 +0000 (+1900) Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=13b9539e825da107ad7e8a95977e414d88c4d58d;p=notmuch-archives.git Re: [PATCH 1/2] configure: add a fallback check for zlib --- diff --git a/28/d3285a7aa036bdf490cb6f8322aa9454467ee1 b/28/d3285a7aa036bdf490cb6f8322aa9454467ee1 new file mode 100644 index 000000000..c08828ffb --- /dev/null +++ b/28/d3285a7aa036bdf490cb6f8322aa9454467ee1 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7060A431FBC + for ; Thu, 22 May 2014 01:27:20 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qHMTvEn95KVJ for ; + Thu, 22 May 2014 01:27:15 -0700 (PDT) +Received: from mail-ob0-f173.google.com (mail-ob0-f173.google.com + [209.85.214.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 524A7431FAE + for ; Thu, 22 May 2014 01:27:15 -0700 (PDT) +Received: by mail-ob0-f173.google.com with SMTP id wm4so3445587obc.4 + for ; Thu, 22 May 2014 01:27:14 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:from:to:message-id:in-reply-to:references:subject:mime-version + :content-type:content-transfer-encoding; + bh=Ltb2idcANitXCy29qPmgmeSelv3kQw0WyZHJznruEyI=; + b=Re8Y5vkNKhTHA3eXESsCImBmxWx+nxBGCOYSpCnXqktEO3B6eBnKknC0NY7hv/m6ou + FBpwRzqHoiewxpzlmDBlqnDIKmgfhmU9or4Y5QOyLx8ZJBGNSTCXeTqhWoD6pc3PgFuo + n8wpeTkpTMF7xbGe5aiqLwmziWgDlDsANdREgeJ8MC8+RG2An4Y09jILcrx3INaCTAPR + y3Uhm0C76hbfjv4jg52hd/hj9R+WCh2vKsoc1DzUH1i2wPpNekpCSlyN/PirqiPiufo4 + hMaCqJGX+zPx1icgtThkXUtqPSmaUb5t70MIZwf1O8iqjLhwRfOck8irR9FQJSxbeAn3 + b3YA== +X-Received: by 10.60.142.169 with SMTP id rx9mr56899621oeb.1.1400747234834; + Thu, 22 May 2014 01:27:14 -0700 (PDT) +Received: from localhost (189-211-224-40.static.axtel.net. [189.211.224.40]) + by mx.google.com with ESMTPSA id + gp4sm18818739obb.17.2014.05.22.01.27.13 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Thu, 22 May 2014 01:27:14 -0700 (PDT) +Date: Thu, 22 May 2014 03:15:58 -0500 +From: Felipe Contreras +To: Fraser Tweedale , + notmuch@notmuchmail.org +Message-ID: <537db23eacf31_1c7bd6f308fd@nysa.notmuch> +In-Reply-To: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au> +References: <1399753646-3026-1-git-send-email-xico@atelo.org> + <536e965c9415e_300d7772fc9@nysa.notmuch> + + <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> + <20140521091304.GT62147@bacardi.hollandpark.frase.id.au> +Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 22 May 2014 08:27:20 -0000 + +Fraser Tweedale wrote: +> On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: +> > Tomi Ollila wrote: +> > > On Sun, May 11 2014, Felipe Contreras = +wrote: +> > > = + +> > > > X=C4=ABc=C3=B2 wrote: +> > > >> Since zlib is part of the base system, FreeBSD chose not to regi= +ster it +> > > >> in pkg-config through zlib.pc. As a fallback test, configure wil= +l build +> > > >> and run a zlib version check and make sure the header and librar= +y +> > > >> versions are compatible. +> > > > +> > > > We could try to generate our on zlib.pc, this way the configure s= +cript +> > > > would be cleaner. +> > > = + +> > > But for that we'd need to figure out the version, and is there simp= +ler +> > > robust way to do that some other way ? +> > = + +> > I don't meant to change the code that is checking for the version in = +the +> > patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.= +c, +> > or something. +> > = + +> = + +> [please cc me in replies; I am not subscribed to the list] + +Unless the list does Reply-To munging, there's no need to say that. And +this is a sane list, so no Reply-To munging :) + +http://felipec.wordpress.com/2010/08/03/avoid-reply-to-munging-mail-as-ma= +il-was-meant-to-be/ + +-- = + +Felipe Contreras=