From: Jameson Graef Rollins Date: Wed, 10 Feb 2016 00:41:01 +0000 (+1600) Subject: Re: [PATCH v3 15/16] added notmuch_message_reindex X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=1394a0cf7bcbd98e7b5997189f887582b7982904;p=notmuch-archives.git Re: [PATCH v3 15/16] added notmuch_message_reindex --- diff --git a/85/f1ec383a7148c7d30d1ea8990cf98c93b0db7c b/85/f1ec383a7148c7d30d1ea8990cf98c93b0db7c new file mode 100644 index 000000000..e515f89db --- /dev/null +++ b/85/f1ec383a7148c7d30d1ea8990cf98c93b0db7c @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 7EB856DE0231 + for ; Tue, 9 Feb 2016 16:41:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.155 +X-Spam-Level: +X-Spam-Status: No, score=-0.155 tagged_above=-999 required=5 tests=[AWL=2.165, + RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id f_VX3r1gwldl for ; + Tue, 9 Feb 2016 16:41:06 -0800 (PST) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by arlo.cworth.org (Postfix) with ESMTPS id 21BBD6DE021E + for ; Tue, 9 Feb 2016 16:41:06 -0800 (PST) +Received: from smtp01.caltech.edu (localhost [127.0.0.1]) + by smtp01.caltech.edu (Postfix) with ESMTP id 7BCDDA1D8A; + Tue, 9 Feb 2016 16:41:04 -0800 (PST) +X-Spam-Scanned: at Caltech-IMSS on smtp01.caltech.edu by amavisd-new +Received: from finestructure.net (gwave-218.ligo.caltech.edu + [131.215.114.218]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 + (256/256 bits)) (No client certificate requested) (Authenticated sender: + jrollins) by smtp-server.its.caltech.edu (Postfix) with ESMTPSA id + 198B9A1935; Tue, 9 Feb 2016 16:41:04 -0800 (PST) +Received: by finestructure.net (Postfix, from userid 1000) + id 05E82601B7; Tue, 9 Feb 2016 16:41:04 -0800 (PST) +From: Jameson Graef Rollins +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v3 15/16] added notmuch_message_reindex +In-Reply-To: <1454272801-23623-16-git-send-email-dkg@fifthhorseman.net> +References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net> + <1454272801-23623-16-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.21+73~g1a7430e (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Tue, 09 Feb 2016 16:41:01 -0800 +Message-ID: <87mvr9s8gy.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha512; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 10 Feb 2016 00:41:08 -0000 + +--=-=-= +Content-Type: text/plain + +On Sun, Jan 31 2016, Daniel Kahn Gillmor wrote: +> This new function asks the database to reindex a given message, using +> the supplied indexopts. +> +> This can be used, for example, to index the cleartext of an encrypted +> message. + +I just wanted to mention that I think there's a problem with the reindex +functionality introduced in this patch (or in 16/16). It looks like +this function irrevocably busts apart threads. dkg and I are +investigating. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iQIcBAEBCgAGBQJWuoceAAoJEO00zqvie6q8ZMcP/1AyF3Tr4lMDqYFSw3rSGiq/ +MdUl4yYPi4pT7evnW8NayhdD+pMOnMiWMxL7EMkR482Q9Y1uixQlHbaTzK0MJnAz +/sfW2BElsQsxxS73BY9sxi/uaXQfHcw6VKxmWNTaH3GlNtpDq43wG+3aOFiMflEp +KXS+5sg2V6MFhVrGh0+jYNazsFY97lLjbxnh3jwbjBzsglAcrKpP5/Q64d5Y91bW +xV0rCFv6d9ol1X77ugPy7V3wqX+o+Qdr3tDM09ImkRz1ZUoruzZlLEm0Ke5ScrTh +QvBa5nI7+6Bal2RZkrsRlRKSju/Ea8hk9KlWPHdOfNDCVyGEPf4LzV+O7PWQmynh +qcHIQ6o4sC/Po8QGtQykKV5a+3kjpf9Wt4hE9WygjPUtNoI2k39fhPZOhdfV1dzI +ZsLOoQtKX36fCd8Zn//1wESJdvqzIh7MQ+tJ7jfsjhvYxaQw7mEkqyv8D3Tbvizk +EIe+YVclWVnUe9LBwUEqIlbQTsQmjXfldySmmyUJUYeg1cIBkD5LLUJgE86cyN6T +l3+GgUVMVkaL12aJMuUqw8VBfpgLhfld4si/GsslCzKRS0TO3UFLLSae+6KRm987 +JzG0L3q0q071SGtbSq0PeMTHSGLnXaOFXAAXarhTSdH7feWR68/jxCcuz7rdk2jc +4kjxnFtHtp+DptxxwIzM +=ZcTh +-----END PGP SIGNATURE----- +--=-=-=--