From: Jani Nikula Date: Sun, 2 Feb 2014 21:19:33 +0000 (+0200) Subject: Re: [PATCH] configure: only install bash completion if supported X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=13912cff48fc024ccc756c5c0320a8de72027fd8;p=notmuch-archives.git Re: [PATCH] configure: only install bash completion if supported --- diff --git a/26/57c3f5b11cfa10226dc4f50d8adf7976be1f10 b/26/57c3f5b11cfa10226dc4f50d8adf7976be1f10 new file mode 100644 index 000000000..aad28536b --- /dev/null +++ b/26/57c3f5b11cfa10226dc4f50d8adf7976be1f10 @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 18224431FBD + for ; Sun, 2 Feb 2014 13:19:48 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id twFZ78NhKaeE for ; + Sun, 2 Feb 2014 13:19:40 -0800 (PST) +Received: from mail-ea0-f176.google.com (mail-ea0-f176.google.com + [209.85.215.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 86A99431FBC + for ; Sun, 2 Feb 2014 13:19:40 -0800 (PST) +Received: by mail-ea0-f176.google.com with SMTP id h14so3329646eaj.7 + for ; Sun, 02 Feb 2014 13:19:36 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=mWKwewTUcwryipPA/d7EQGMleBKulBXMb3zXMtP49wc=; + b=ajPyjaDmKmzaHKkZ+02fGI6+fPlprjuIJZ8uBLucI5FAkNcFJmjId5x91LmnYZXi3/ + A5362YLFqxPE39bkkl6rDXtTdoreziam4sHc/pOMq/xRwXJATYRsLU8fDhIpf8fV14Dm + 64pCvzc+cZ2oAo/y4enHZGDNf8koPVv5Mi1tnWoLnGGuclk3kGF2HRiWYxnalO7iG0kv + 3j2a6sgATDR9Psx2SNZjrP8vIixe2P5vhuJlMSdN1KFenykfWZ2e4fAI5APyet8P31kz + XhSrUueZA6/2McT8KIvec6kasGhs0bOb+FlN0HK1S949FlpYzyYDlQ+ziLlIwkp+rqAi + ahdg== +X-Gm-Message-State: + ALoCoQnFwm3eQ63EG48wEwE/BKAluQMHNmYJoDFMn1VoQtdlmRu6bpfOfzvDhTwTLXDq6qvaXwdq +X-Received: by 10.14.88.131 with SMTP id a3mr3399354eef.64.1391375976603; + Sun, 02 Feb 2014 13:19:36 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) + by mx.google.com with ESMTPSA id k6sm66566142eep.17.2014.02.02.13.19.34 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 02 Feb 2014 13:19:35 -0800 (PST) +From: Jani Nikula +To: David Bremner , + Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] configure: only install bash completion if supported +In-Reply-To: <878utt1b9s.fsf@maritornes.cs.unb.ca> +References: <1391359677-12497-1-git-send-email-jani@nikula.org> + <877g9dqup5.fsf@qmul.ac.uk> <878utt1b9s.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.17+44~ge3b4cd9 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 02 Feb 2014 23:19:33 +0200 +Message-ID: <87vbwxw6u2.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Feb 2014 21:19:48 -0000 + +On Sun, 02 Feb 2014, David Bremner wrote: +> Mark Walters writes: +> +>> This LGTM (untested) +> +> I did test it, at least completely removing bash completion works as +> expected. +> +> Unfortunately --with-bash-completion does not override this test because +> the order things are processed. Do you think this is a bug? I wondered +> if users that "know what they are doing" (TM) might want to force +> installation even though the pkg-config test fails. + +I thought it was a feature, not a bug, but I'm fine either way. + +BR, +Jani.