From: David Bremner Date: Sun, 7 Aug 2016 13:32:54 +0000 (+0900) Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=13810445e5437fdd8205dc948f97a2afd7a787a6;p=notmuch-archives.git Re: [PATCH v4 02/16] Move crypto.c into libutil --- diff --git a/ff/cb2f4b56c3a30c864fea74fbacdaeddb3748e1 b/ff/cb2f4b56c3a30c864fea74fbacdaeddb3748e1 new file mode 100644 index 000000000..99e7dbf8a --- /dev/null +++ b/ff/cb2f4b56c3a30c864fea74fbacdaeddb3748e1 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 69BFC6DE00DB + for ; Sun, 7 Aug 2016 06:33:14 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.008 +X-Spam-Level: +X-Spam-Status: No, score=-0.008 tagged_above=-999 required=5 tests=[AWL=0.003, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fMtYxX4Pu6qP for ; + Sun, 7 Aug 2016 06:33:06 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 8AD646DE0217 + for ; Sun, 7 Aug 2016 06:33:01 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) + (envelope-from ) + id 1bWOCX-0007T2-Ae; Sun, 07 Aug 2016 09:33:13 -0400 +Received: (nullmailer pid 30865 invoked by uid 1000); + Sun, 07 Aug 2016 13:32:54 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil +In-Reply-To: <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net> +References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net> + <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 07 Aug 2016 22:32:54 +0900 +Message-ID: <87h9awu2k9.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 07 Aug 2016 13:33:14 -0000 + +Daniel Kahn Gillmor writes: + +> This prepares us for using the crypto object in both the library and +> the client. +> +> i've prefixed notmuch_crypto with _ to indicate that while this can be +> built into the library when needed, it's not something to be exported +> or used externally. + +I started to review this series on top of [1], but I didn't get +much past here because of the build failure. I guess there will be at +least one more small change needed because of the alternative way I +ended up doing "remove all properties". I find + +% git rebase -i -x "make test" + +an effective way of making sure things are in a good state after every +patch. At least it's effective when I remember to do it; just before +writing this, I discovered a rebasing error in [1] that caused a similar +build failure. + +[1]: id:1470491559-3946-1-git-send-email-david@tethera.net