From: W. Trevor King <wking@tremily.us>
Date: Sat, 18 Jan 2014 19:46:48 +0000 (-0800)
Subject: CHANGELOG: Document this branch
X-Git-Tag: v3.9~9^2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=137386d12cac825f9592db42c9996eebb88f9398;p=rss2email.git

CHANGELOG: Document this branch

And add a warning about toggling the setting for active feeds.

For both George and me, the motivation for this change was working
around feed authors that change the id after minor changes in content:

  On Sat, Jan 18, 2014 at 1:40 PM, W. Trevor King wrote:
  > Some of the newspaper feeds I follow have duplicate entries in
  > their feed if they tweaked the title or content, but I rarely care
  > about the changes.

  On Sat, Jan 18, 2014 at 02:16:19PM -0500, George Saunders wrote:
  > That's exactly the situation I added it for.

The Atom spec explicitly says that revisions should keep the same id
[1]:

  When an Atom Document is relocated, migrated, syndicated,
  republished, exported, or imported, the content of its atom:id
  element MUST NOT change.  Put another way, an atom:id element
  pertains to all instantiations of a particular Atom entry or feed;
  revisions retain the same content in their atom:id elements.

But not all feed generators are fully compliant ;).

[1]: http://tools.ietf.org/search/rfc4287#section-4.2.6

Signed-off-by: W. Trevor King <wking@tremily.us>
---

diff --git a/CHANGELOG b/CHANGELOG
index 03b42cb..a866fa6 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,4 +1,5 @@
 v3.8 (unreleased)
+    * Add a new `trust-link` setting, to prefer the `link` attribute over the `id` attribute for identifying entries.
     * Sluggify feed names on opmlimport.
     * Allow Unicode letters and digits in feed names, instead of just ASCII lettters and digits.
 
diff --git a/README b/README
index 2e1f0b7..fcb5f48 100644
--- a/README
+++ b/README
@@ -141,7 +141,8 @@ entries converted to plain text::
   html-mail = True
 
 To be notified every time a post changes, instead of just when it's
-first posted::
+first posted (see also ``trust-link``, described in
+``rss2email/config.py``)::
 
   trust-guid = True
 
diff --git a/rss2email/config.py b/rss2email/config.py
index 1f9ebbe..40c4c0f 100644
--- a/rss2email/config.py
+++ b/rss2email/config.py
@@ -109,6 +109,9 @@ CONFIG['DEFAULT'] = _collections.OrderedDict((
         ('trust-guid', str(True)),
         # True: Receive one email per unique link url.
         # False: Defer to trust-guid preference.
+        # Toggling this for existing feeds may result in duplicates,
+        # because the old entries will not be recorded under their new
+        # link-based ids.
         ('trust-link', str(False)),
         # To most correctly encode emails with international
         # characters, we iterate through the list below and use the