From: Shawn O. Pearce <spearce@spearce.org>
Date: Fri, 14 Sep 2007 07:31:11 +0000 (-0400)
Subject: Remove unnecessary debugging from builtin-fetch
X-Git-Tag: v1.5.4-rc0~292^2~59
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=133296f00cd441b5525ccc3e82ee13cbfc62d246;p=git.git

Remove unnecessary debugging from builtin-fetch

The older git-fetch client did not produce all of this debugging
information to stdout.  Most end-users and Porcelain (e.g. StGIT,
git-gui, qgit) do not want to see these low-level details on the
console so they should be removed.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin-fetch-pack.c b/builtin-fetch-pack.c
index 3b217d96f..e77cd2671 100644
--- a/builtin-fetch-pack.c
+++ b/builtin-fetch-pack.c
@@ -767,8 +767,6 @@ struct ref *fetch_pack(const char *dest, int nr_heads, char **heads)
 			st.st_mtime = 0;
 	}
 
-	printf("connect to %s\n", dest);
-
 	pid = git_connect(fd, (char *)dest, uploadpack,
                           verbose ? CONNECT_VERBOSE : 0);
 	if (pid < 0)
diff --git a/builtin-fetch.c b/builtin-fetch.c
index 016c6e43e..33b740cd1 100644
--- a/builtin-fetch.c
+++ b/builtin-fetch.c
@@ -370,15 +370,6 @@ static int do_fetch(struct transport *transport,
 	for (rm = ref_map; rm; rm = rm->next) {
 		if (rm->peer_ref)
 			read_ref(rm->peer_ref->name, rm->peer_ref->old_sha1);
-
-		printf("%s : %s\n", rm->name, rm->peer_ref ? rm->peer_ref->name : NULL);
-		printf("  < %s\n", sha1_to_hex(rm->old_sha1));
-		if (rm->peer_ref)
-			printf("  > %s\n", sha1_to_hex(rm->peer_ref->old_sha1));
-		if (!rm->peer_ref ||
-		    hashcmp(rm->old_sha1, rm->peer_ref->old_sha1)) {
-			printf("%s needs update.\n", rm->name);
-		}
 	}
 
 	if (fetch_refs(transport, ref_map)) {