From: Zac Medico Date: Sun, 27 Apr 2008 21:25:20 +0000 (-0000) Subject: Fix the EbuildQuote check to ignore "echo" and the elog functions since X-Git-Tag: v2.2_pre6~95 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=12b18d776b62da31709d42f49903eb0c0423fcda;p=portage.git Fix the EbuildQuote check to ignore "echo" and the elog functions since people might not want quotes in those cases. svn path=/main/trunk/; revision=10006 --- diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py index bc1c29115..8f9fd1abc 100644 --- a/pym/repoman/checks.py +++ b/pym/repoman/checks.py @@ -76,7 +76,10 @@ class EbuildQuote(LineCheck): """Ensure ebuilds have valid quoting around things like D,FILESDIR, etc...""" repoman_check_name = 'ebuild.minorsyn' - ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)|(^\s*(local|export)\s+)') + _ignored_commands = ["echo", "local", "export"] + _ignored_commands += ["eerror", "einfo", "elog", "eqawarn", "ewarn"] + ignore_line = re.compile(r'(^$)|(^\s*#.*)|(^\s*\w+=.*)' + \ + r'|(^\s*(' + "|".join(_ignored_commands) + r')\s+)') var_names = ["D", "DISTDIR", "FILESDIR", "S", "T", "ROOT", "WORKDIR"] # variables for games.eclass