From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 27 Jul 2015 19:36:23 +0000 (+0300)
Subject: Re: [PATCH] build: add "set -e" to version script generation
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=125a5b9ff7705069f1137d2b251a2f4948cd4c9a;p=notmuch-archives.git

Re: [PATCH] build: add "set -e" to version script generation
---

diff --git a/04/d44e1e10836012e95e14cbfde8abef4af25460 b/04/d44e1e10836012e95e14cbfde8abef4af25460
new file mode 100644
index 000000000..cf38fde1a
--- /dev/null
+++ b/04/d44e1e10836012e95e14cbfde8abef4af25460
@@ -0,0 +1,83 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id F0A0C6DE14FD
+ for <notmuch@notmuchmail.org>; Mon, 27 Jul 2015 12:36:47 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.955
+X-Spam-Level: 
+X-Spam-Status: No, score=0.955 tagged_above=-999 required=5 tests=[AWL=0.303, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id L1Wc9mhUF0pp for <notmuch@notmuchmail.org>;
+ Mon, 27 Jul 2015 12:36:45 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 0952B6DE14D9
+ for <notmuch@notmuchmail.org>; Mon, 27 Jul 2015 12:36:45 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 27AB8100086;
+ Mon, 27 Jul 2015 22:36:24 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] build: add "set -e" to version script generation
+In-Reply-To: <1438022552-24342-1-git-send-email-david@tethera.net>
+References: <1438022552-24342-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.20.2+31~g967a7a3 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 27 Jul 2015 22:36:23 +0300
+Message-ID: <m2a8uh75qg.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 27 Jul 2015 19:36:48 -0000
+
+On Mon, Jul 27 2015, David Bremner <david@tethera.net> wrote:
+
+> It turns out that on certain systems like FreeBSD, c++filt is not
+> installed by default. It's basically OK if we fail the build in that
+> case, but what's really not OK is for the build to continue and
+> generate bad binaries.
+> ---
+>  lib/gen-version-script.sh | 1 +
+>  1 file changed, 1 insertion(+)
+>
+> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
+> index 64a7374..aa1ca43 100644
+> --- a/lib/gen-version-script.sh
+> +++ b/lib/gen-version-script.sh
+> @@ -1,3 +1,4 @@
+> +set -e
+
+LGTM, although I'd prefer 'set -eu' (both visual observation and testing
+with set -eux worked for me).
+
+Tomi
+
+
+>  
+>  # we go through a bit of work to get the unmangled names of the
+>  # typeinfo symbols because of
+> -- 
+> 2.1.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch