From: Etienne Millon <me@emillon.org>
Date: Mon, 10 Dec 2012 14:02:03 +0000 (+0100)
Subject: Don't put UTF8 last in the list of encodings
X-Git-Tag: v3.0~43
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=11c8237badda3d0aadd58d964d0bcd4f9a6ffc83;p=rss2email.git

Don't put UTF8 last in the list of encodings

Sometimes, BIG5 will be selected for english text if quotes make it
not representable in ASCII. See [1] for the original bug report.

This default list is arguably European-centric but at least it documents a good
amount of the alternative encodings.

[1]: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659920

Reported-by: James Cloos <cloos@jhcloos.com>
Signed-off-by: Etienne Millon <me@emillon.org>
---

diff --git a/rss2email/config.py b/rss2email/config.py
index d8dc073..afe2725 100644
--- a/rss2email/config.py
+++ b/rss2email/config.py
@@ -89,9 +89,8 @@ CONFIG['DEFAULT'] = _collections.OrderedDict((
         ('trust-guid', str(True)),
         # To most correctly encode emails with international
         # characters, we iterate through the list below and use the
-        # first character set that works Eventually (and
-        # theoretically) UTF-8 is our catch-all failsafe.
-        ('encodings', 'US-ASCII, BIG5, ISO-2022-JP, ISO-8859-1, UTF-8'),
+        # first character set that works.
+        ('encodings', 'US-ASCII, ISO-8859-1, UTF-8, BIG5, ISO-2022-JP'),
         ## HTML conversion
         # True: Send text/html messages when possible.
         # False: Convert HTML to plain text.